Skip to contentSkip to conversation

Document when printk is useable

PATCH New Benjamin Herrenschmidt 1 participant 1 message May 7, 2008 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Document when printk is useable

When debugging early boot problems, it's common to sprinkle printk's all over the place. However, on powerpc 64 bits, this can lead to memory corruption if done too early due to the PACA pointer and lockdep core not being initialized.

This adds some comments to early_setup() that document when it is safe to do so in order to save time to whoever has to debug that stuff next.

---

 arch/powerpc/kernel/setup_64.c |    4 ++++
 1 file changed, 4 insertions(+)
arch/powerpc/kernel/setup_64.c +4 -0
@@ -170,6 +170,8 @@ void __init setup_paca(int cpu)
 
 void __init early_setup(unsigned long dt_ptr)
 {
+	/* -------- printk is _NOT_ safe to use here ! ------- */
+
 	/* Fill in any unititialised pacas */
 	initialise_pacas();
 
@@ -185,6 +187,8 @@ void __init early_setup(unsigned long dt
 	/* Initialize lockdep early or else spinlocks will blow */
 	lockdep_init();
 
+	/* -------- printk is now safe to use ------- */
+
  	DBG(" -> early_setup(), dt_ptr: 0x%lx\n", dt_ptr);
 
 	/*