Skip to contentSkip to conversation

sound/video: fix sound/i2c/other/tea575x-tuner.c build bug

PATCH In review Ingo Molnar 3 participants 4 messages Apr 29, 2008 – May 8, 2008 Sound

lore
Share & tools
lore

Ingo Molnar

author
#0 lore raw

PATCH 1/1 sound/video: fix sound/i2c/other/tea575x-tuner.c build bug

fix build failure triggered on latest -git by this config:

http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad

sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function) sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.) sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known

the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT APIs.

Signed-off-by Ingo Molnar <[email protected]>
---
 sound/pci/Kconfig |    1 +
 1 file changed, 1 insertion(+)
sound/pci/Kconfig +1 -0
Index: linux/sound/pci/Kconfig
===================================================================
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
 	select VIDEO_V4L1
+	select VIDEO_V4L1_COMPAT
 	select VIDEO_DEV
 
 config SND_HDA_INTEL
#1 lore raw

At Tue, 29 Apr 2008 22:46:43 +0200,

Quoted 6 lines · Ingo Molnar

fix build failure triggered on latest -git by this config:

http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad

Quoted 8 lines

sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function) sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.) sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known

the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT APIs.

I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things messy enough. And more select, eh... IMO, this should be rather depend on VIDEO_V4L1.

But, there is a dependency chain problem among snd-fm801, snd-fm801-tea575x and V4L layer. I'll check it.

Takashi

Quoted 19 lines
Signed-off-by Ingo Molnar <[email protected]>
---
 sound/pci/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux/sound/pci/Kconfig
===================================================================

sound/pci/Kconfig +1 -0
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
 	select VIDEO_V4L1
+	select VIDEO_V4L1_COMPAT
 	select VIDEO_DEV
 
 config SND_HDA_INTEL
#2 lore raw

On Wed, 30 Apr 2008 12:41:52 +0200
Takashi Iwai <[email protected]> wrote:

Takashi,

I'm assuming that you're handing this issue, right?

Quoted 10 lines

sound/pci/Kconfig config SND_FM801_TEA575X · line 533

Quoted 10 lines

Index: linux/sound/pci/Kconfig
===================================================================

sound/pci/Kconfig +1 -0
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
 	select VIDEO_V4L1
+	select VIDEO_V4L1_COMPAT
 	select VIDEO_DEV

Hmm... VIDEO_V4L1 where renamed as VIDEO_ALLOW_V4L1. Probably, this is what's broken for SND_FM801_TEA575X.

Cheers,
Mauro

#3 lore raw

At Wed, 7 May 2008 16:36:28 -0300,

Quoted 7 lines · Mauro Carvalho Chehab

On Wed, 30 Apr 2008 12:41:52 +0200
Takashi Iwai <[email protected]> wrote:

Takashi,

I'm assuming that you're handing this issue, right?

Yes, and it was already fixed on Linus git tree.
The selects are converted to depend.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Index: linux/sound/pci/Kconfig
===================================================================

sound/pci/Kconfig +0 -0
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
Quoted 8 lines
Quoted 5 lines

sound/pci/Kconfig config SND_FM801_TEA575X · line 533

Quoted 5 lines
sound/pci/Kconfig +1 -0
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
 	select VIDEO_V4L1
+	select VIDEO_V4L1_COMPAT
 	select VIDEO_DEV

Hmm... VIDEO_V4L1 where renamed as VIDEO_ALLOW_V4L1. Probably, this is what's broken for SND_FM801_TEA575X.

Partly yes.

thanks,

Takashi