minios: clear FB content

PATCH New Samuel Thibault 1 participant 1 message May 8, 2008

lore

Share & tools

lore

Samuel Thibault

author

2008-05-08 14:34 UTC #0 lore raw

PATCH 1/1 minios: clear FB content

minios: clear FB content since _xmalloc may return non-zeroed memory (in debug mode, notably).

Signed-off-by Samuel Thibault <[email protected]>

extras/mini-os/kernel.c +2 -5

diff -r 2223ed7635d4 extras/mini-os/kernel.c
@@ -302,13 +302,10 @@
 
     memsize = n * PAGE_SIZE;
     fb = _xmalloc(memsize, PAGE_SIZE);
+    memset(fb, 0, memsize);
     mfns = xmalloc_array(unsigned long, n);
-    for (i = 0; i < n; i++) {
-        /* trigger CoW */
-        ((char *) fb) [i * PAGE_SIZE] = 0;
-        barrier();
+    for (i = 0; i < n; i++)
         mfns[i] = virtual_to_mfn((char *) fb + i * PAGE_SIZE);
-    }
     fb_dev = init_fbfront(NULL, mfns, WIDTH, HEIGHT, DEPTH, line_length, n);
     xfree(mfns);
     if (!fb_dev) {