Skip to contentSkip to conversation

Enabled NMI support for KVM

RFC PATCH In review Yang, Sheng 2 participants 3 messages May 8, 2008 KVM

lore
Share & tools
lore
#0 lore raw

cover Enabled NMI support for KVM

Hi

This patchset enabled NMI support for KVM.

The first three patches enabled NMI for in-kernel irqchip and NMI supporting on VMX. The last patch enabled NMI watchdog in linux, can be used to test the NMI injection.

In fact, this series should also included Jan Kiszka's patch to enable NMI for userspace irqchip, but now I got little trouble to get the merged version work on my machine... We would post it as soon as we solved it.

Another thing is the vmx_intr_assist() and do_interrupt_requests() got some duplication. And the logic for normal interrupt and NMI is similiar, but vmx_intr_assist() seems a little implicit...

Any comments welcome!

--
Thanks
Yang, Sheng

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

#1 lore raw
Quoted 12 lines · Sheng

Hi

This patchset enabled NMI support for KVM.

The first three patches enabled NMI for in-kernel irqchip and NMI supporting on VMX. The last patch enabled NMI watchdog in linux, can be used to test the NMI injection.

In fact, this series should also included Jan Kiszka's patch to enable NMI for userspace irqchip, but now I got little trouble to get the merged version work on my machine... We would post it as soon as we solved it.

Quoted 5 lines

Another thing is the vmx_intr_assist() and do_interrupt_requests() got some duplication. And the logic for normal interrupt and NMI is similiar, but vmx_intr_assist() seems a little implicit...

Any comments welcome!

To make rebasing my work easier (hope I find some time later today):
Your patches show up line-wrapped here. Could you check and repost?

Thanks,
Jan

Signature · 8 lines
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
#2 lore raw
Quoted 13 lines · Jan Kiszka
Quoted 12 lines · Sheng

Hi

This patchset enabled NMI support for KVM.

The first three patches enabled NMI for in-kernel irqchip and NMI supporting on VMX. The last patch enabled NMI watchdog in linux, can be used to test the NMI injection.

In fact, this series should also included Jan Kiszka's patch to enable NMI for userspace irqchip, but now I got little trouble to get the merged version work on my machine... We would post it as soon as we solved it.

Quoted 8 lines
Quoted 5 lines

Another thing is the vmx_intr_assist() and do_interrupt_requests() got some duplication. And the logic for normal interrupt and NMI is similiar, but vmx_intr_assist() seems a little implicit...

Any comments welcome!

To make rebasing my work easier (hope I find some time later today):
Your patches show up line-wrapped here. Could you check and repost?

Missed the attachments on first glance, and they are fine.

Jan

Signature · 8 lines
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone