stuff
Subsystems (3)
=46rom: J. Bruce Fields <[email protected]>
Commit f15364bd4cf8799a7677b6daeed7b67d9139d974 ("IPv6 support for NFS server export caches") dropped a couple spaces, rendering the output here difficult to read.
(However note that we expect the output to be parsed only by humans, no= t
machines, so this shouldn't have broken any userland software.)
@linux-ipv6.org>
--- net/sunrpc/svcauth_unix.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
I just noticed this while doing some debugging at Connectathon. I'm undecided whether to take it seriously. Does anyone other than me use these /content files? I suppose it should probably go into 2.6.26 but not 2.6.25.x.
--b.
net/sunrpc/svcauth_unix.c +0 -0
@@ -278,7 +278,7 @@ static int ip_map_show(struct seq_file *m, dom =3D im->m_client->h.name;
=20
if (ipv6_addr_v4mapped(&addr)) {
- seq_printf(m, "%s" NIPQUAD_FMT "%s\n",
+ seq_printf(m, "%s " NIPQUAD_FMT " %s\n",
im->m_class, ntohl(addr.s6_addr32[3]) >> 24 & 0xff, ntohl(addr.s6_addr32[3]) >> 16 & 0xff,
@@ -286,7 +286,7 @@ static int ip_map_show(struct seq_file *m,
ntohl(addr.s6_addr32[3]) >> 0 & 0xff, dom);
} else {
- seq_printf(m, "%s" NIP6_FMT "%s\n",
+ seq_printf(m, "%s " NIP6_FMT " %s\n",
im->m_class, NIP6(addr), dom);
}
return 0;
--=20
1.5.5.rc1
PATCH 1/1 Fix /proc/net/rpc/auth.unix.ip/content output [Was Re: stuff]
Um, sorry about that subject line.
Quoted 3 lines · J. Bruce Fields
From: J. Bruce Fields <[email protected]>
=20
Commitf15364bd4cf8799a7677b6daeed7b67d9139d974("IPv6 support for NF=
S
Quoted 4 lines
server export caches") dropped a couple spaces, rendering the output here difficult to read.
=20
(However note that we expect the output to be parsed only by humans, =
not
Quoted 7 lines
machines, so this shouldn't have broken any userland software.) =20
Signed-off-by J. Bruce Fields <[email protected]>Cc Aurelien Charbon <[email protected]>Cc Neil Brown <[email protected]>Cc Brian Haley <[email protected]>Cc YOSHIFUJI Hideaki / =E5=90=89=E8=97=A4=E8=8B=B1=E6=98=8E <yoshfu=
Quoted 7 lines
=20
--- net/sunrpc/svcauth_unix.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)=20
I just noticed this while doing some debugging at Connectathon. I'm undecided whether to take it seriously. Does anyone other than me us=
e
Quoted 1 line
these /content files? I suppose it should probably go into 2.6.26 bu=
t
Quoted 27 lines
not 2.6.25.x.
=20
--b.
=20net/sunrpc/svcauth_unix.c +0
-0@@ -278,7 +278,7 @@ static int ip_map_show(struct seq_file *m, dom =3D im->m_client->h.name;=20
net/sunrpc/svcauth_unix.c +2
-3if (ipv6_addr_v4mapped (&addr)) { - seq_printf(m, "%s" NIPQUAD_FMT "%s\n", + seq_printf(m, "%s " NIPQUAD_FMT " %s\n", im->m_class, ntohl(addr.s6_addr32[3]) >> 24 & 0xff, ntohl(addr.s6_addr32[3]) >> 16 & 0xff,@@ -286,7 +286,7 @@ static int ip_map_show(struct seq_file *m,ntohl (addr.s6_addr32[3 ]) >>0 &0xff , dom); }else { -seq_printf (m,"%s" NIP6_FMT "%s\n" , +seq_printf (m,"%s " NIP6_FMT " %s\n" , im->m_class,NIP6 (addr), dom); }return 0 ; --=20
Quoted 4 lines
1.5.5.rc1
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" =
in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix /proc/net/rpc/auth.unix.ip/content output [Was Re: stuff]
Quoted 1 line · On Friday May 9, [email protected] wrote:
Um, sorry about that subject line.
I liked it ;-) Gave a bit of an informal feel....
Quoted 5 lines
=20
Quoted 3 lines · J. Bruce Fields
From: J. Bruce Fields <[email protected]>
=20
Commitf15364bd4cf8799a7677b6daeed7b67d9139d974("IPv6 support for =
NFS
Quoted 1 line
Quoted 1 line
server export caches") dropped a couple spaces, rendering the outpu=
t
Quoted 3 lines
Quoted 3 lines
here difficult to read.
=20
(However note that we expect the output to be parsed only by humans=
, not
Quoted 7 lines
Quoted 7 lines
machines, so this shouldn't have broken any userland software.) =20
Signed-off-by J. Bruce Fields <[email protected]>Cc Aurelien Charbon <[email protected]>Cc Neil Brown <[email protected]>Cc Brian Haley <[email protected]>Cc YOSHIFUJI Hideaki / =E5=90=1B(Ih=1B$(O$h=8B=B1=E6=98=8E=1B(B <=
Quoted 6 lines
Quoted 6 lines
=20
--- net/sunrpc/svcauth_unix.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)=20
I just noticed this while doing some debugging at Connectathon. I'=
m
Quoted 1 line
Quoted 1 line
undecided whether to take it seriously. Does anyone other than me =
use
Quoted 1 line
Quoted 1 line
these /content files? I suppose it should probably go into 2.6.26 =
but
Quoted 1 line
Quoted 1 line
not 2.6.25.x.
I don't think any code uses them, but it's very good to be able to look at them when something doesn't seem to be working as expected.
But I don't think the patch would apply to 2.6.25. 'git name-rev' on the offending commit say:
f15364bd4cf8799a7677b6daeed7b67d9139d974 tags/v2.6.26-rc1~1083^2~47
which means it was in 2.6.26-rc1 but not the previous release.
NeilBrown
A message that is not in the archive (sent off-list or not yet received): 18471.35859.781495.449872-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org
Re: [PATCH] Fix /proc/net/rpc/auth.unix.ip/content output [Was Re: stuff]
Quoted 6 lines · Neil Brown
But I don't think the patch would apply to 2.6.25. 'git name-rev' on the offending commit say:
f15364bd4cf8799a7677b6daeed7b67d9139d974tags/v2.6.26-rc1~1083^2~47which means it was in 2.6.26-rc1 but not the previous release.
Ah! You're right--I lose track of time too easily.
--b.