Skip to contentSkip to conversation

OMAP3 clock: two small fixes

PATCH In review Paul Walmsley 2 participants 4 messages May 8, 2008 – May 9, 2008

Subsystems (4)
lore
Share & tools
lore

Paul Walmsley

author maintainer
#0 lore raw

cover OMAP3 clock: two small fixes

Two minor OMAP3 clock framework fixes. This series:

- puts the sys_clkout2 struct clk into the core_clkdm where it belongs

- removes the omap2_noncore_dpll_set_rate() function pointer from the DPLL3 struct clk (since DPLL3 is the CORE DPLL)

- Paul

---

 arch/arm/mach-omap2/clock34xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
author maintainer
#1 lore raw

PATCH 1/2 OMAP3 clock: move sys_clkout2 clk to core_clkdm

sys_clkout2 belongs in the core_clkdm (3430 TRM section 4.7.2.2). It's not clear whether it actually is in the CORE clockdomain, or whether it is technically in a different clockdomain; but this is closer to reality than the present configuration.

---

 arch/arm/mach-omap2/clock34xx.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/clock34xx.h +1 -0
index 85afe1e..825bab4 100644
@@ -978,6 +978,7 @@ static struct clk clkout2_src_ck = {
 	.clksel_mask	= OMAP3430_CLKOUT2SOURCE_MASK,
 	.clksel		= clkout2_src_clksel,
 	.flags		= CLOCK_IN_OMAP343X | RATE_PROPAGATES,
+	.clkdm_name	= "core_clkdm",
 	.recalc		= &omap2_clksel_recalc,
 };
 
author maintainer
#2 lore raw

PATCH 2/2 OMAP3 clock: remove omap3_noncore_dpll_set_rate fn from CORE DPLL definition

In reply to Paul Walmsley

DPLL3 is the CORE DPLL and cannot use the non-CORE set_rate function since SDRC is downstream.

---

 arch/arm/mach-omap2/clock34xx.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/clock34xx.h +0 -1
index 825bab4..284c796 100644
@@ -411,7 +411,6 @@ static struct clk dpll3_ck = {
 	.dpll_data	= &dpll3_dd,
 	.flags		= CLOCK_IN_OMAP343X | RATE_PROPAGATES | ALWAYS_ENABLED,
 	.round_rate	= &omap2_dpll_round_rate,
-	.set_rate	= &omap3_noncore_dpll_set_rate,
 	.recalc		= &omap3_dpll_recalc,
 };
 
maintainer
#3 lore raw
In reply to Paul Walmsley
Quoted 6 lines · Paul Walmsley

Two minor OMAP3 clock framework fixes. This series:

- puts the sys_clkout2 struct clk into the core_clkdm where it belongs

- removes the omap2_noncore_dpll_set_rate() function pointer from the DPLL3 struct clk (since DPLL3 is the CORE DPLL)

Pushing.

Tony

Quoted 14 lines

- Paul

---

 arch/arm/mach-omap2/clock34xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html