s390/net/claw: don't ignore return value of find_link

RFC PATCH New Marcin Slusarz 1 participant 1 message May 11, 2008

Subsystems (3)

Network drivers s390 s390 network drivers

lore

Share & tools

lore

Marcin Slusarz

author

2008-05-11 19:58 UTC #0 lore raw

RFC PATCH 1/1 s390/net/claw: don't ignore return value of find_link

find_link checked some conditions but then ignored it - fix it. return negative error for consistency with the rest of kernel

Signed-off-by Marcin Slusarz <[email protected]>

Cc Martin Schwidefsky <[email protected]>

---
please check if it's correct patch

---
 drivers/s390/net/claw.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/s390/net/claw.c +4 -4

@@ -1722,18 +1722,18 @@ find_link(struct net_device *dev, char *host_name, char *ws_name )
 		case  PACKING_ASK:
 			if ((memcmp(WS_APPL_NAME_PACKED, host_name, 8)!=0) ||
 			    (memcmp(WS_APPL_NAME_PACKED, ws_name, 8)!=0 ))
-        	             rc = EINVAL;
+				rc = -EINVAL;
 			break;
 		case  DO_PACKED:
 		case  PACK_SEND:
 			if ((memcmp(WS_APPL_NAME_IP_NAME, host_name, 8)!=0) ||
 			    (memcmp(WS_APPL_NAME_IP_NAME, ws_name, 8)!=0 ))
-        	        	rc = EINVAL;
+				rc = -EINVAL;
 			break;
 		default:
 	       		if ((memcmp(HOST_APPL_NAME, host_name, 8)!=0) ||
 		    	    (memcmp(p_env->api_type , ws_name, 8)!=0))
-        	        	rc = EINVAL;
+				rc = -EINVAL;
 			break;
 	}

@@ -1741,7 +1741,7 @@ find_link(struct net_device *dev, char *host_name, char *ws_name )
         printk(KERN_INFO "%s:%s Exit on line %d\n",
 		dev->name,__func__,__LINE__);
 #endif
-        return 0;
+	return rc;
 }    /*    end of find_link    */
 
 /*-------------------------------------------------------------------*