Skip to contentSkip to conversation

dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL

RFC PATCH In review Marcin Slusarz 2 participants 2 messages May 11, 2008 – May 12, 2008 Distributed lock manager (DLM)

lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw

RFC PATCH 1/1 dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL

Signed-off-by Marcin Slusarz <[email protected]>
Cc Christine Caulfield <[email protected]>
Cc David Teigland <[email protected]>
Cc [email protected]

---
it's probably a typo, but I'm not sure
please check if it's the right fix (maybe this condition should be dropped?) (compile tested only)

---
 fs/dlm/lowcomms.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/dlm/lowcomms.c +1 -1
@@ -930,7 +930,7 @@ out_err:
 	 * errors we try again until the max number of retries is reached.
 	 */
 	if (result != -EHOSTUNREACH && result != -ENETUNREACH &&
-	    result != -ENETDOWN && result != EINVAL
+	    result != -ENETDOWN && result != -EINVAL
 	    && result != -EPROTONOSUPPORT) {
 		lowcomms_connect_sock(con);
 		result = 0;