Skip to contentSkip to conversation

net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path

PATCH In review Marcin Slusarz 2 participants 2 messages May 11, 2008 – May 12, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path

ERR_PTR takes negative errno as a parameter

Cc Tom Tucker <[email protected]>
Cc J. Bruce Fields <[email protected]>

---
compile tested only

---
 net/sunrpc/xprtrdma/svc_rdma_transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sunrpc/xprtrdma/svc_rdma_transport.c +1 -1
@@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
 
 	cma_xprt = rdma_create_xprt(serv, 1);
 	if (!cma_xprt)
-		return ERR_PTR(ENOMEM);
+		return ERR_PTR(-ENOMEM);
 	xprt = &cma_xprt->sc_xprt;
 
 	listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);
#1 lore raw

Thanks! But I think Tom is just doing some final revisions on a patch series that already includes this fix?

--b.

Quoted 24 lines · Marcin Slusarz

ERR_PTR takes negative errno as a parameter

Cc Tom Tucker <[email protected]>
Cc J. Bruce Fields <[email protected]>

---
compile tested only

---
 net/sunrpc/xprtrdma/svc_rdma_transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sunrpc/xprtrdma/svc_rdma_transport.c +1 -1
@@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
 
 	cma_xprt = rdma_create_xprt(serv, 1);
 	if (!cma_xprt)
-		return ERR_PTR(ENOMEM);
+		return ERR_PTR(-ENOMEM);
 	xprt = &cma_xprt->sc_xprt;
 
 	listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);