Skip to contentSkip to conversation

ACPI 2.6.26-rc2: Add missing newline to DSDT/SSDT warning message

PATCH Applied Alistair John Strachan 2 participants 2 messages May 12, 2008 – May 14, 2008 ACPI

lore
Share & tools
lore

Alistair John Strachan

author
#0 lore raw

PATCH 1/1 ACPI 2.6.26-rc2: Add missing newline to DSDT/SSDT warning message

As of recently (probably 2.6.26-rc1) I've been getting the following mangling in the kernel log:

[4294014.568167] ACPI: DSDT override uses original SSDTs unless "acpi_no_auto_ssdt"<6>CPU0: Intel(R) Pentium(R) Dual  CPU  E2160  @ 1.80GHz stepping 0d

This is due to a missing newline character in the first message. The following patch against 2.6.26-rc2 fixes it. Please apply.

Signed-off-by Alistair John Strachan <[email protected]>

---

drivers/acpi/tables/tbxface.c +1 -1
index fb57b93..0e31960 100644
@@ -540,7 +540,7 @@ static acpi_status acpi_tb_load_namespace(void)
 		acpi_tb_print_table_header(0, table);
 
 		if (no_auto_ssdt == 0) {
-			printk(KERN_WARNING "ACPI: DSDT override uses original SSDTs unless \"acpi_no_auto_ssdt\"");
+			printk(KERN_WARNING "ACPI: DSDT override uses original SSDTs unless \"acpi_no_auto_ssdt\"\n");
 		}
 	}
Signature · 4 lines
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.
reviewer Applied
#1 lore raw

applied.

thanks,
-len

Quoted 24 lines · Alistair John Strachan

As of recently (probably 2.6.26-rc1) I've been getting the following mangling in the kernel log:

[4294014.568167] ACPI: DSDT override uses original SSDTs unless "acpi_no_auto_ssdt"<6>CPU0: Intel(R) Pentium(R) Dual  CPU  E2160  @ 1.80GHz stepping 0d

This is due to a missing newline character in the first message. The following patch against 2.6.26-rc2 fixes it. Please apply.

Signed-off-by Alistair John Strachan <[email protected]>

---

drivers/acpi/tables/tbxface.c +1 -1
index fb57b93..0e31960 100644
@@ -540,7 +540,7 @@ static acpi_status acpi_tb_load_namespace(void)
 		acpi_tb_print_table_header(0, table);
 
 		if (no_auto_ssdt == 0) {
-			printk(KERN_WARNING "ACPI: DSDT override uses original SSDTs unless \"acpi_no_auto_ssdt\"");
+			printk(KERN_WARNING "ACPI: DSDT override uses original SSDTs unless \"acpi_no_auto_ssdt\"\n");
 		}
 	}