: ftrace: Remove packed attribute on ftrace_page.
PATCH 1/2 : ftrace: Remove packed attribute on ftrace_page.
It causes unaligned access traps on platforms like sparc (ftrace_page may be marked packed, but once we return a dyn_ftrace sub-object from this array to another piece of code, the "packed" part of the typing information doesn't propagate).
But also, it didn't serve any purpose either. Even if packed, on 64-bit or 32-bit, it didn't give us any more dyn_ftrace entries per-page.
--- kernel/trace/ftrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/trace/ftrace.c +2 -2
@@ -177,9 +177,9 @@ static DEFINE_MUTEX(ftrace_filter_lock);struct ftrace_page {struct ftrace_page *next; -int index; +unsigned long index;struct dyn_ftrace records[]; -} __attribute__((packed)); +};#define ENTRIES_PER_PAGE \ ((PAGE_SIZE - sizeof(struct ftrace_page)) / sizeof(struct dyn_ftrace))
Signature · 1 line
1.5.5.rc0.16.g02b00
Quoted 11 lines · David Miller
It causes unaligned access traps on platforms like sparc (
ftrace_pagemay be marked packed, but once we return adyn_ftracesub-object from this array to another piece of code, the "packed" part of the typing information doesn't propagate).But also, it didn't serve any purpose either. Even if packed, on 64-bit or 32-bit, it didn't give us any more
dyn_ftraceentries per-page.Signed-off-by David S. Miller <[email protected]>
-- Steve