Skip to contentSkip to conversation

xfsqa - fix 17[5-7] "unmount" typo

PATCH In review David Chinner 2 participants 2 messages May 13, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfsqa - fix 17[5-7] "unmount" typo

177 fails because mkfs tries to run on a mounted filesystem. All 17[5-7] have the same problem - "unmount" is not the command to unmount a filesystem.

---
 xfstests/175 |    2 +-
 xfstests/176 |    2 +-
 xfstests/177 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
xfstests/175 +1 -1
Index: xfs-cmds/xfstests/175
===================================================================
@@ -40,7 +40,7 @@ _require_scratch
 
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 
 # _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 # 					"ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 ws2" \
xfstests/176 +1 -1
Index: xfs-cmds/xfstests/176
===================================================================
@@ -38,7 +38,7 @@ _require_scratch
 
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 
 # _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 # 					"ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 ws2" \
xfstests/177 +1 -1
Index: xfs-cmds/xfstests/177
===================================================================
@@ -40,7 +40,7 @@ _require_scratch
 
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 
 _scratch_mkfs_xfs >/dev/null 2>&1 \
         || _fail "mkfs failed"
#1 lore raw
Quoted 3 lines · David Chinner

177 fails because mkfs tries to run on a mounted filesystem. All 17[5-7] have the same problem - "unmount" is not the command to unmount a filesystem.

Looks fine (or looks fie).

Quoted 40 lines
---
 xfstests/175 |    2 +-
 xfstests/176 |    2 +-
 xfstests/177 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Index: xfs-cmds/xfstests/175
===================================================================

xfstests/175 +1 -1
@@ -40,7 +40,7 @@ _require_scratch
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 # _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 # 					"ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 ws2" \

Index: xfs-cmds/xfstests/176
===================================================================

xfstests/176 +1 -1
@@ -38,7 +38,7 @@ _require_scratch
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 # _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 # 					"ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 ws2" \

Index: xfs-cmds/xfstests/177
===================================================================

xfstests/177 +1 -1
@@ -40,7 +40,7 @@ _require_scratch
 # test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
 _scratch_mkfs_xfs >/dev/null 2>&1 \
         || _fail "mkfs failed"