dvb: drivers/media/dvb/ttpci/fdump firmware build error fix

x86.git testing found the following build failure in 2.6.26-rc2:

drivers/media/dvb/ttpci/fdump "/usr/lib/hotplug/firmware/dvb-ttpci-01.fw" dvb_ttpci_fw drivers/media/dvb/ttpci/av7110_firm.h firmware file '/usr/lib/hotplug/firmware/dvb-ttpci-01.fw' not found
make[4]: *** [drivers/media/dvb/ttpci/av7110_firm.h] Error 255
make[3]: *** [drivers/media/dvb/ttpci] Error 2

in this config:

http://redhat.com/~mingo/misc/config-Mon_May_12_11_29_29_CEST_2008.bad

the reason for the build bug is that the driver's Kconfig ignores the PREVENT_FIRMWARE_BUILD=y config setting and tries to build the firmware which (like other firmware build methods) relies on a non-upstream firmware blob. The fix is to make the firmware build depend on !PREVENT_FIRMWARE_BUILD.

Signed-off-by Ingo Molnar <[email protected]>

---
 drivers/media/dvb/ttpci/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/media/dvb/ttpci/Kconfig
===================================================================

drivers/media/dvb/ttpci/Kconfig config DVB_AV7110 · line 36

Quoted 2 lines · Ingo Molnar

drivers/media/dvb/ttpci/Kconfig +1 -1

-     depends on DVB_AV7110 && !STANDALONE
+     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...

Quoted 3 lines · Oliver Endriss

Quoted 2 lines · Ingo Molnar

drivers/media/dvb/ttpci/Kconfig +1 -1

-     depends on DVB_AV7110 && !STANDALONE
+     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

Quoted 2 lines

If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...

The point of PREVENT_FIRMWARE_BUILD is to make build testing with "make randconfig" possible. I think you should ACK this patch, it doesn't have any downsides for users of this driver.

Quoted 5 lines · Johannes Stezenbach

Quoted 3 lines · Oliver Endriss

Quoted 2 lines · Ingo Molnar

drivers/media/dvb/ttpci/Kconfig +1 -1

-     depends on DVB_AV7110 && !STANDALONE
+     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

Quoted 7 lines

Quoted 2 lines

If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...

The point of PREVENT_FIRMWARE_BUILD is to make build testing with "make randconfig" possible. I think you should ACK this patch, it doesn't have any downsides for users of this driver.

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, the same problem will happen again...

The problem is that randconfig does not know what to do (i.e. provide a firmware file) when it selects DVB_AV7110_FIRMWARE=y.

The driver depends on STANDALONE, and that should be sufficient:

| CONFIG_STANDALONE:
|   Select this option if you don't have magic firmware for drivers that
|   need it.

while CONFIG_PREVENT_FIRMWARE_BUILD means:

| CONFIG_PREVENT_FIRMWARE_BUILD:
|   Say yes to avoid building firmware. Firmware is usually shipped
|   with the driver, and only when updating the firmware a rebuild
|   should be made.

Imho randconfig should always set STANDALONE=y.

Quoted 8 lines · Johannes Stezenbach

Quoted 6 lines · Oliver Endriss

drivers/media/dvb/ttpci/Kconfig config DVB_AV7110 · line 36

Quoted 2 lines · Ingo Molnar

drivers/media/dvb/ttpci/Kconfig +1 -1

-     depends on DVB_AV7110 && !STANDALONE
+     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...

Quoted 4 lines

The point of PREVENT_FIRMWARE_BUILD is to make build testing with "make randconfig" possible. I think you should ACK this patch, it doesn't have any downsides for users of this driver.

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, the same problem will happen again...

The driver depends on STANDALONE, and that should be sufficient:

| CONFIG_STANDALONE:
|   Select this option if you don't have magic firmware for drivers that
|   need it.

while CONFIG_PREVENT_FIRMWARE_BUILD means:

| CONFIG_PREVENT_FIRMWARE_BUILD:
|   Say yes to avoid building firmware. Firmware is usually shipped
|   with the driver, and only when updating the firmware a rebuild
|   should be made.

Quoted 6 lines

Quoted 3 lines

The point of PREVENT_FIRMWARE_BUILD is to make build testing with "make randconfig" possible. I think you should ACK this patch, it doesn't have any downsides for users of this driver.

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, the same problem will happen again...

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Quoted 14 lines · Oliver Endriss

Quoted 12 lines · Johannes Stezenbach

Quoted 6 lines · Oliver Endriss

drivers/media/dvb/ttpci/Kconfig config DVB_AV7110 · line 36

Quoted 2 lines · Ingo Molnar

drivers/media/dvb/ttpci/Kconfig +1 -1

-     depends on DVB_AV7110 && !STANDALONE
+     depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD

If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...

The point of PREVENT_FIRMWARE_BUILD is to make build testing with "make randconfig" possible. I think you should ACK this patch, it doesn't have any downsides for users of this driver.

Quoted 2 lines

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, the same problem will happen again...

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Quoted 4 lines

The driver depends on STANDALONE, and that should be sufficient:

| CONFIG_STANDALONE:
|   Select this option if you don't have magic firmware for drivers that
|   need it.

this is for excluding drivers which don't _work_ without firmware

Quoted 5 lines

while CONFIG_PREVENT_FIRMWARE_BUILD means:

| CONFIG_PREVENT_FIRMWARE_BUILD:
|   Say yes to avoid building firmware. Firmware is usually shipped
|   with the driver, and only when updating the firmware a rebuild
|   should be made.

and this is for excluding drivers which don't _build_ without firmware (badly worded, it certainly doesn't mean to build the firmware, but build a C source file from the firmware)

Quoted 4 lines

Quoted 2 lines

No. If randconfig deselects both STANDALONE and PREVENT_FIRMWARE_BUILD, the same problem will happen again...

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

Quoted 1 line · Johannes Stezenbach

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

Quoted 7 lines · Oliver Endriss

Quoted 1 line · Johannes Stezenbach

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

It is desirable to have one generic "don't break the build because of missing firmware binaries" option, isn't it?

Quoted 11 lines · Johannes Stezenbach

Quoted 7 lines · Oliver Endriss

Quoted 1 line · Johannes Stezenbach

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

It is desirable to have one generic "don't break the build because of missing firmware binaries" option, isn't it?

it's a bit confusing. PREVENT_FIRMWARE_BUILD=y is the 'weaker' option - a driver might still be operational (with its default firmware), even if no firmware is built. STANDALONE=y is the stronger option - if a driver depends on that it means that the driver cannot be built (and used) at all without a firmware file. To be on the safe side users who have no firmware needs should set both options. (and that's the default as well)

Quoted 15 lines · Ingo Molnar

Quoted 11 lines · Johannes Stezenbach

Quoted 7 lines · Oliver Endriss

Quoted 1 line · Johannes Stezenbach

You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config.

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

It is desirable to have one generic "don't break the build because of missing firmware binaries" option, isn't it?

Quoted 6 lines

it's a bit confusing. PREVENT_FIRMWARE_BUILD=y is the 'weaker' option - a driver might still be operational (with its default firmware), even if no firmware is built. STANDALONE=y is the stronger option - if a driver depends on that it means that the driver cannot be built (and used) at all without a firmware file. To be on the safe side users who have no firmware needs should set both options. (and that's the default as well)

Seems like I'm confused now...

CONFIG_STANDALONE
Prompt: Select only drivers that don't need compile-time external firmware

PREVENT_FIRMWARE_BUILD
Prompt: Prevent firmware from being built

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

Quoted 4 lines · Oliver Endriss

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

hm, you are right - i've added STANDALONE=y previously but it went missing in action. So forget my patch, it was user error - the driver is right in that it already depends on STANDALONE :-) I guess STANDALONE should enable PREVENT_FIRMWARE_BUILD as well to avoid such errors ...

Quoted 4 lines · Oliver Endriss

Sure. And without the patch you can simply add
- STANDALONE=y or
- DVB_AV7110_FIRMWARE=n
to your allrandom.config. ;-)

hm, you are right - i've added STANDALONE=y previously but it went missing in action. So forget my patch, it was user error - the driver is right in that it already depends on STANDALONE :-)

I guess STANDALONE
should enable PREVENT_FIRMWARE_BUILD as well to avoid such errors ...