Export __lock_page_killable()
Subsystems (2)
PATCH 1/1 Export __lock_page_killable()
Hi.
There are users, who would like to use lock_page_killable() in modules, so far there are no users in kernel, but for consistency it can be exported without them.
Not that it is particulary needed, but copying page_waitqueue() in modules is frowned upon and unlikely to be exported either.
As a side note, do we want interruptible and time limited locking for those who knows what is being done?
mm/filemap.c +1 -0
@@ -610,6 +610,7 @@ int __lock_page_killable(struct page *page)return __wait_on_bit_lock (page_waitqueue (page), &wait, sync_page_killable,TASK_KILLABLE ); } +EXPORT_SYMBOL (__lock_page_killable);/** * __lock_page_nosync - get a lock on the page, without calling sync_page()
Signature · 1 line
Evgeniy Polyakov
Quoted 5 lines · On Wed, 14 May 2008 18:11:58 +0400 Evgeniy Polyakov <[email protected]> wrote:
Hi.
There are users, who would like to use
lock_page_killable()in modules, so far there are no users in kernel, but for consistency it can be exported without them.
Missing information #1: Who are the users and what are the URLs to the code in question
Quoted 1 line
Not that it is particulary needed
Humm..
Quoted 1 line
+EXPORT_SYMBOL(__lock_page_killable);
_GPL - or better yet this could be added *when* we have an actual in tree user who really needs it and can show it is appropriate to export. That'll also save Adrian from removing it again ;)
Hi Alan.
Quoted 6 lines · Alan Cox
Quoted 3 lines
There are users, who would like to use
lock_page_killable()in modules, so far there are no users in kernel, but for consistency it can be exported without them.Missing information #1: Who are the users and what are the URLs to the code in question
POHMELFS wants to use that in two places: one to lock page in writeback, another one is about second part of the message - it waits for timeout or signal or locks the page. If page can not be locked, it performs own steps, not sleeps forever...
POHMELFS is a high performance network filesystem, homepage for interested reader:
http://tservice.net.ru/~s0mbre/old/?section=projects&item=pohmelfs
or yesterdays mail to mail lists:
http://lwn.net/Articles/282010/
Quoted 3 lines
Quoted 1 line
Not that it is particulary needed
Humm..
I copied page_waitqueue() and use wait_on_bit() logic myself. Andrew choked with his breakfast when saw that.
Quoted 5 lines
Quoted 1 line
+EXPORT_SYMBOL(__lock_page_killable);
_GPL- or better yet this could be added *when* we have an actual in tree user who really needs it and can show it is appropriate to export. That'll also save Adrian from removing it again ;)
No problem wiht GPL-only exporting, but carring it over the whole release means no ability to build out-of-tree module.
Actually what I want to hear, is that it is needed or not at all...
Signature · 1 line
Evgeniy Polyakov
Andrew Morton
maintainerQuoted 1 line · On Wed, 14 May 2008 18:32:15 +0400 Evgeniy Polyakov <[email protected]> wrote:
Actually what I want to hear, is that it is needed or not at all...
Yes, I think it's a reasonable thing to export. We could do it now as part of a "make the API complete" exercise but more typically we'd do it when merging code which needs that export.