Support for Aztek Networks cta5000s - Resubmittal
PATCH 1/1 Support for Aztek Networks cta5000s - Resubmittal
This patch to u-boot-1.3.3 adds support for the Aztek Networks, Inc. cta5000s. The board hosts a Freescale mpc8250, 64MB of SDRAM and 2 MB of flash. The cta5000s hardware uses the Analog and Micro Rattler 8250 as a reference. The software uses components from the TQM8260 and the pq2ads boards.
Configuration Manager
PATCH 1/2 Added support for Aztek Networks cta5000s.
--- CREDITS | 12 ++++++++++++ MAINTAINERS | 8 ++++++++ MAKEALL | 1 + Makefile | 3 +++ 4 files changed, 24 insertions(+), 0 deletions(-)
CREDITS +12 -0
@@ -61,6 +61,10 @@ N: Jon Benediktsson E: jonb at marel.is D: Support for Marel V37 board +N: Jim Black +E: jblack at azteknetworks.com +D: Support for cta5000s board + N: Raphael Bossek E: raphael.bossek at solutions4linux.de D: 8xxrom-0.3.0
@@ -188,6 +192,10 @@ N: Kirk Haderlie E: khaderlie at vividimage.com D: Added TFTP to 8xxrom (-> 0.3.1) +N: Jeffrey Haemer +E: jhaemer at azteknetworks.com +D: Support for cta5000s board + N: Chris Hallinan E: clh at net1plus.com D: DHCP Support
@@ -326,6 +334,10 @@ E: dan at embeddedalley.com D: FADSROM, the grandfather of all of this D: Support for Silicon Turnkey eXpress XTc +N: Scott Mann +E: smann at azteknetworks.com +D: Support for cta5000s board + N: Andrea "llandre" Marson E: andrea.marson at dave-tech.it D: Port to PPChameleonEVB board
MAINTAINERS +8 -0
@@ -50,6 +50,10 @@ Jerry Van Baren <[email protected]> sacsng MPC8260 +Jim Black <[email protected]> + + cta5000s MPC8250 + Oliver Brown <[email protected]> gw8260 MPC8260
@@ -194,6 +198,10 @@ Howard Gray <[email protected]> MVS1 MPC823 +Jeffrey Haemer <[email protected]> + + cta5000s MPC8250 + Joe Hamman <[email protected]> sbc8548 MPC8548
MAKEALL +1 -0
@@ -283,6 +283,7 @@ LIST_8260=" \ cogent_mpc8260 \ CPU86 \ CPU87 \ + cta5000s \ ep8248 \ ep8260 \ ep82xxm \
Makefile +3 -0
@@ -1714,6 +1714,9 @@ Rattler_config: unconfig @echo "#define CONFIG_MPC8248" > $(obj)include/config.h) @$(MKCONFIG) -a Rattler ppc mpc8260 rattler +cta5000s_config: unconfig + @$(MKCONFIG) $(@:_config=) ppc mpc8260 cta5000s + RPXsuper_config: unconfig @$(MKCONFIG) $(@:_config=) ppc mpc8260 rpxsuper
Signature · 1 line
1.5.5.1
PATCH 2/2 Added support for Aztek Networks cta5000s telecom board.
--- board/cta5000s/Makefile | 50 +++ board/cta5000s/config.mk | 30 ++ board/cta5000s/cta5000s.c | 575 +++++++++++++++++++++++++++++++++++ include/configs/cta5000s.h | 723 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 1378 insertions(+), 0 deletions(-) create mode 100644 board/cta5000s/Makefile create mode 100644 board/cta5000s/config.mk create mode 100644 board/cta5000s/cta5000s.c create mode 100644 include/configs/cta5000s.h
board/cta5000s/Makefile new file +50 -0
@@ -0,0 +1,50 @@ +# +# (C) Copyright 2001-2006 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS := $(BOARD).o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/cta5000s/config.mk new file +30 -0
@@ -0,0 +1,30 @@ +# +# (C) Copyright 2001-2005 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# Modified by, Yuli Barcohen, Arabella Software Ltd. <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +# +# Rattler series boards by Analogue & Micro +# + +TEXT_BASE = 0xFE000000
board/cta5000s/cta5000s.c new file +575 -0
575 lines not on this page · raw message
include/configs/cta5000s.h new file +723 -0
723 lines not on this page · raw message
Signature · 1 line
1.5.5.1
PATCH 2/2 Added support for Aztek Networks cta5000s telecom board.
Quoted 10 lines · In message <[email protected]> you…
--- board/cta5000s/Makefile | 50 +++ board/cta5000s/config.mk | 30 ++ board/cta5000s/cta5000s.c | 575 +++++++++++++++++++++++++++++++++++ include/configs/cta5000s.h | 723 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 1378 insertions(+), 0 deletions(-) create mode 100644 board/cta5000s/Makefile create mode 100644 board/cta5000s/config.mk create mode 100644 board/cta5000s/cta5000s.c create mode 100644 include/configs/cta5000s.h
There is trailing white space in some of the files.
Please use TABs for indentation instead of spaces (Not only at the beginning of the lines).
Quoted 4 lines
+/* See
include/configs/cta5000s.hfor CFG_* settings
+ * All values in the following tables taken from
+ * chapter 6 of the cta Programmer's Guide
+ */
...
Quoted 2 lines
+/* Compact Flash Control Registers
+ */
...
Quoted 2 lines
+/* Compact Flash IO memory
+ */
These comments, and many others, are not in the requested format for multiline comments.
And I dare to ask if this:
Quoted 2 lines
+/* FPGA memory
+ */
really requires a multiline comment?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The more we disagree, the more chance there is that at least one of us is right.
PATCH 1/2 Added support for Aztek Networks cta5000s.
In reply to Jim BlackQuoted 6 lines · Jim Black
--- CREDITS | 12 ++++++++++++ MAINTAINERS | 8 ++++++++ MAKEALL | 1 + Makefile | 3 +++ 4 files changed, 24 insertions(+), 0 deletions(-)
<snip>
Quoted 13 lines
+++ b/MAINTAINERS
MAINTAINERS +4
-0@@ -50,6 +50,10 @@ Jerry Van Baren <[email protected]> sacsng MPC8260 +Jim Black <[email protected]> + + cta5000s MPC8250 + Oliver Brown <[email protected]> gw8260 MPC8260
MAINTAINERS Howard Gray <[email protected]> · line 204
Quoted 7 lines
MAINTAINERS +4
-0@@ -194,6 +198,10 @@ Howard Gray <[email protected]> MVS1 MPC823 +Jeffrey Haemer <[email protected]> + + cta5000s MPC8250 +
Two maintainers for one board? This could cause problems. I suggest that you internally decide who will be "officially" responsible.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================