mips: use the common ascii hex helpers
PATCH 10/12 mips: use the common ascii hex helpers
Signed-off-by Harvey Harrison <[email protected]>
--- arch/mips/kernel/gdb-stub.c | 24 +++++++++--------------- 1 files changed, 9 insertions(+), 15 deletions(-)
arch/mips/kernel/gdb-stub.c +9 -15
@@ -190,7 +190,6 @@ static char input_buffer[BUFMAX];static char output_buffer[BUFMAX ];static int initialized;/* !0 means we've been initialized */ static int kgdb_started; -static const char hexchars[]="0123456789abcdef" ;/* Used to prevent crashes in memory access. Note that they'll crash anyway if we haven't set up fault handlers yet... */
@@ -306,8 +305,8 @@ static void putpacket(char *buffer) }putDebugChar ('#' ); -putDebugChar (hexchars[checksum >>4 ]); -putDebugChar (hexchars[checksum &0xf ]); +putDebugChar (hex_asc_hi (checksum)); +putDebugChar (hex_asc_lo (checksum)); }while ((getDebugChar () &0x7f ) !='+' );
@@ -328,8 +327,7 @@ static unsigned char *mem2hex(char *mem, char *buf, int count, int may_fault)while (count-- >0 ) {if (kgdb_read_byte (mem++, &ch) !=0 )return 0 ; - *buf++ = hexchars[ch >>4 ]; - *buf++ = hexchars[ch &0xf ]; + buf =pack_hex_byte (buf, ch); } *buf =0 ;
@@ -812,14 +810,12 @@ void handle_exception(struct gdb_regs *regs)* Send trap type (converted to signal) */ *ptr++ ='T' ; - *ptr++ = hexchars[sigval >>4 ]; - *ptr++ = hexchars[sigval &0xf ]; + ptr =pack_hex_byte (ptr, sigval);/* * Send Error PC */ - *ptr++ = hexchars[REG_EPC >>4 ]; - *ptr++ = hexchars[REG_EPC &0xf ]; + ptr =pack_hex_byte (ptr,REG_EPC ); *ptr++ =':' ; ptr =mem2hex ((char *)®s->cp0_epc, ptr,sizeof (long ),0 ); *ptr++ =';' ;
@@ -827,8 +823,7 @@ void handle_exception(struct gdb_regs *regs)/* * Send frame pointer */ - *ptr++ = hexchars[REG_FP >>4 ]; - *ptr++ = hexchars[REG_FP &0xf ]; + ptr =pack_hex_byte (ptr,REG_FP ); *ptr++ =':' ; ptr =mem2hex ((char *)®s->reg30, ptr,sizeof (long ),0 ); *ptr++ =';' ;
@@ -836,8 +831,7 @@ void handle_exception(struct gdb_regs *regs)/* * Send stack pointer */ - *ptr++ = hexchars[REG_SP >>4 ]; - *ptr++ = hexchars[REG_SP &0xf ]; + ptr =pack_hex_byte (ptr,REG_SP ); *ptr++ =':' ; ptr =mem2hex ((char *)®s->reg29, ptr,sizeof (long ),0 ); *ptr++ =';' ;
@@ -856,8 +850,8 @@ void handle_exception(struct gdb_regs *regs) {case '?' : output_buffer[0 ] ='S' ; - output_buffer[1 ] = hexchars[sigval >>4 ]; - output_buffer[2 ] = hexchars[sigval &0xf ]; + output_buffer[1 ] =hex_asc_hi (sigval); + output_buffer[2 ] =hex_asc_lo (sigval); output_buffer[3 ] =0 ;break ;
Signature · 1 line
1.5.5.1.404.g981f6
On Mon, May 12, 2008 at 12:05:43PM -0700, Harvey Harrison wrote:
And the MIPS bits also:
Acked-by Ralf Baechle <[email protected]>
Ralf