Skip to contentSkip to conversation

tip build broken on sparc64...

DISCUSSION David Miller 3 participants 4 messages May 16, 2008 – May 19, 2008

lore
Share & tools
lore
#0 lore raw

It's this pteval_t stuff, probably breaks just about every other platforms as well.

Please fix this, because I'd like to work on some ftrace optimizations on sparc64, and do some testing of ftrace in general.

mm/mmap.c: In function 'vm_get_page_prot_preserve':
mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function) mm/mmap.c:86: error: (Each undeclared identifier is reported only once mm/mmap.c:86: error: for each function it appears in.) mm/mmap.c:86: error: expected ';' before 'newprotval' mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

#1 lore raw
Quoted 7 lines · David Miller

It's this pteval_t stuff, probably breaks just about every other platforms as well.

Please fix this, because I'd like to work on some ftrace optimizations on sparc64, and do some testing of ftrace in general.

Quoted 6 lines

mm/mmap.c: In function 'vm_get_page_prot_preserve':
mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function) mm/mmap.c:86: error: (Each undeclared identifier is reported only once mm/mmap.c:86: error: for each function it appears in.) mm/mmap.c:86: error: expected ';' before 'newprotval' mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

ok, will take care of it now.

Ingo

#2 lore raw
Quoted 9 lines · Ingo Molnar
Quoted 7 lines · David Miller

It's this pteval_t stuff, probably breaks just about every other platforms as well.

Please fix this, because I'd like to work on some ftrace optimizations on sparc64, and do some testing of ftrace in general.

Quoted 8 lines
Quoted 6 lines

mm/mmap.c: In function 'vm_get_page_prot_preserve':
mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function) mm/mmap.c:86: error: (Each undeclared identifier is reported only once mm/mmap.c:86: error: for each function it appears in.) mm/mmap.c:86: error: expected ';' before 'newprotval' mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

ok, will take care of it now.

That was a conflict of mprotect patches, which is resolved. Just checked that current -tip builds a sparc64 defconfig.

Thanks,

tglx

#3 lore raw

From: Thomas Gleixner <[email protected]>
Date: Mon, 19 May 2008 18:15:43 +0200 (CEST)

Quoted 17 lines · Ingo Molnar
Quoted 16 lines · David Miller
Quoted 14 lines

It's this pteval_t stuff, probably breaks just about every other platforms as well.

Please fix this, because I'd like to work on some ftrace optimizations on sparc64, and do some testing of ftrace in general.

mm/mmap.c: In function 'vm_get_page_prot_preserve':
mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function) mm/mmap.c:86: error: (Each undeclared identifier is reported only once mm/mmap.c:86: error: for each function it appears in.) mm/mmap.c:86: error: expected ';' before 'newprotval' mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

Quoted 4 lines
Quoted 1 line

ok, will take care of it now.

That was a conflict of mprotect patches, which is resolved. Just checked that current -tip builds a sparc64 defconfig.

Thanks a lot.