Skip to contentSkip to conversation

t7701-repack-unpack-unreachable.sh: check timestamp of unpacked objects

PATCH In review [email protected] 4 participants 6 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t7701-repack-unpack-unreachable.sh: check timestamp of unpacked objects

From: Brandon Casey <[email protected]>

Unpacked objects should receive the timestamp of the pack they were unpacked from. Check.

---
 t/t7701-repack-unpack-unreachable.sh |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
t/t7701-repack-unpack-unreachable.sh +28 -0
index 6a5211f..bdb00d4 100755
@@ -4,6 +4,10 @@ test_description='git-repack works correctly'
 
 . ./test-lib.sh
 
+fsha1=
+csha1=
+tsha1=
+
 test_expect_success '-A option leaves unreachable objects unpacked' '
 	echo content > file1 &&
 	git add . &&
@@ -44,4 +48,28 @@ test_expect_success '-A option leaves unreachable objects unpacked' '
 	git show $tsha1
 '
 
+test_expect_success 'unpacked objects receive timestamp of pack file' '
+	fsha1path=$(echo "$fsha1" | sed -e "s/\(..\)\(.*\)/\1\/\2/") &&
+	fsha1path=".git/objects/$fsha1path" &&
+	csha1path=$(echo "$csha1" | sed -e "s/\(..\)\(.*\)/\1\/\2/") &&
+	csha1path=".git/objects/$csha1path" &&
+	tsha1path=$(echo "$tsha1" | sed -e "s/\(..\)\(.*\)/\1\/\2/") &&
+	tsha1path=".git/objects/$tsha1path" &&
+	git branch transient_branch $csha1 &&
+	git repack -a -d -l &&
+	test ! -f "$fsha1path" &&
+	test ! -f "$csha1path" &&
+	test ! -f "$tsha1path" &&
+	test 1 = $(ls -1 .git/objects/pack/pack-*.pack | wc -l) &&
+	packfile=$(ls .git/objects/pack/pack-*.pack) &&
+	git branch -D transient_branch &&
+	git repack -A -l &&
+	test -f "$fsha1path" -a ! "$fsha1path" -nt "$packfile" -a \
+				! "$fsha1path" -ot "$packfile" &&
+	test -f "$csha1path" -a ! "$csha1path" -nt "$packfile" -a \
+				! "$csha1path" -ot "$packfile" &&
+	test -f "$tsha1path" -a ! "$tsha1path" -nt "$packfile" -a \
+				! "$tsha1path" -ot "$packfile"
+'
+
 test_done
Signature · 1 line
1.5.5.1.447.geb0a7
#1 lore raw

t/t7701-repack-unpack-unreachable.sh test_expect_success '-A option leaves unreachable objects unpacked' ' · line 73

Quoted 7 lines · [email protected] writes:
t/t7701-repack-unpack-unreachable.sh +7 -0
+	test -f "$fsha1path" -a ! "$fsha1path" -nt "$packfile" -a \
+				! "$fsha1path" -ot "$packfile" &&
+	test -f "$csha1path" -a ! "$csha1path" -nt "$packfile" -a \
+				! "$csha1path" -ot "$packfile" &&
+	test -f "$tsha1path" -a ! "$tsha1path" -nt "$packfile" -a \
+				! "$tsha1path" -ot "$packfile"
+'

"Test" primaries -nt/-ot are unfortunately excluded from POSIX.

#2 lore raw
Quoted 12 lines · Junio C Hamano

t/t7701-repack-unpack-unreachable.sh test_expect_success '-A option leaves unreachable objects unpacked' ' · line 73

Quoted 7 lines · [email protected] writes:
t/t7701-repack-unpack-unreachable.sh +7 -0
+	test -f "$fsha1path" -a ! "$fsha1path" -nt "$packfile" -a \
+				! "$fsha1path" -ot "$packfile" &&
+	test -f "$csha1path" -a ! "$csha1path" -nt "$packfile" -a \
+				! "$csha1path" -ot "$packfile" &&
+	test -f "$tsha1path" -a ! "$tsha1path" -nt "$packfile" -a \
+				! "$tsha1path" -ot "$packfile"
+'

"Test" primaries -nt/-ot are unfortunately excluded from POSIX.

hrmph, and it even worked on solaris ksh.

-brandon

#3 lore raw
Quoted 13 lines · Brandon Casey
Quoted 11 lines · Junio C Hamano

t/t7701-repack-unpack-unreachable.sh test_expect_success '-A option leaves unreachable objects unpacked' ' · line 73

Quoted 7 lines · [email protected] writes:
t/t7701-repack-unpack-unreachable.sh +7 -0
+	test -f "$fsha1path" -a ! "$fsha1path" -nt "$packfile" -a \
+				! "$fsha1path" -ot "$packfile" &&
+	test -f "$csha1path" -a ! "$csha1path" -nt "$packfile" -a \
+				! "$csha1path" -ot "$packfile" &&
+	test -f "$tsha1path" -a ! "$tsha1path" -nt "$packfile" -a \
+				! "$tsha1path" -ot "$packfile"
+'

"Test" primaries -nt/-ot are unfortunately excluded from POSIX.

Quoted 1 line

hrmph, and it even worked on solaris ksh.

FYI, also works with dash, and there is a use of '-nt' in git-mergetool.sh which is not exercised by the test suite.

Maybe I'll think about a perl version.

Also, do you have a url to your posix reference?

-brandon