remove CODA_FS_OLD_API
Subsystems (2)
RFC PATCH 1/1 remove CODA_FS_OLD_API
While fixing CONFIG_ leakages to the userspace kernel headers I ran into CODA_FS_OLD_API.
After five years, are there still people using the old API left? Especially considering that you have to choose at compile time which API to support in the kernel (and distributions tend to offer the new API for some time).
Signed-off-by Adrian Bunk <[email protected]>
---
fs/Kconfig | 14 -------------- fs/coda/coda_linux.c | 6 ++---- fs/coda/psdev.c | 4 ---- fs/coda/upcall.c | 15 +-------------- include/linux/coda.h | 43 ------------------------------------------- 5 files changed, 3 insertions(+), 79 deletions(-)
b4f57f48c803fe6d5373546ab477f39ef0fd75ee diff --git a/fs/Kconfig b/fs/Kconfig index ab21a4c..86439a9 100644
fs/Kconfig +0 -14
@@ -2048,20 +2048,6 @@ config CODA_FS To compile the coda client support as a module, choose M here: the module will be called coda. -config CODA_FS_OLD_API - bool "Use 96-bit Coda file identifiers" - depends on CODA_FS - help - A new kernel-userspace API had to be introduced for Coda v6.0 - to support larger 128-bit file identifiers as needed by the - new realms implementation. - - However this new API is not backward compatible with older - clients. If you really need to run the old Coda userspace - cache manager then say Y. - - For most cases you probably want to say N. - config AFS_FS tristate "Andrew File System support (AFS) (EXPERIMENTAL)" depends on INET && EXPERIMENTAL
fs/coda/coda_linux.c +2 -4
@@ -28,11 +28,9 @@ int coda_fake_statfs;char *coda_f2s (struct CodaFid *f) {static char s[60 ]; -#ifdef CONFIG_CODA_FS_OLD_API -sprintf (s,"(%08x.%08x.%08x)" , f->opaque[0 ], f->opaque[1 ], f->opaque[2 ]); -#else +sprintf (s,"(%08x.%08x.%08x.%08x)" , f->opaque[0 ], f->opaque[1 ], f->opaque[2 ], f->opaque[3 ]); -#endif +return s; }
fs/coda/psdev.c +0 -4
@@ -377,11 +377,7 @@ MODULE_AUTHOR("Jan Harkes, Peter J. Braam");MODULE_DESCRIPTION ("Coda Distributed File System VFS interface" );MODULE_ALIAS_CHARDEV_MAJOR (CODA_PSDEV_MAJOR );MODULE_LICENSE ("GPL" ); -#ifdef CONFIG_CODA_FS_OLD_API -MODULE_VERSION ("5.3.21" ); -#else MODULE_VERSION ("6.6" ); -#endif static int __init init_coda (void ) {
fs/coda/upcall.c +1 -14
@@ -52,12 +52,8 @@ static void *alloc_upcall(int opcode, int size) inp->ih.opcode = opcode; inp->ih.pid = current->pid; inp->ih.pgid =task_pgrp_nr (current); -#ifdef CONFIG_CODA_FS_OLD_API -memset (&inp->ih.cred,0 ,sizeof (struct coda_cred )); - inp->ih.cred.cr_fsuid = current->fsuid; -#else inp->ih.uid = current->fsuid; -#endif +return (void *)inp; }
@@ -166,20 +162,11 @@ int venus_close(struct super_block *sb, struct CodaFid *fid, int flags,union inputArgs *inp;union outputArgs *outp;int insize, outsize, error; -#ifdef CONFIG_CODA_FS_OLD_API -struct coda_cred cred = {0 , }; - cred.cr_fsuid = uid; -#endif insize =SIZE (release);UPARG (CODA_CLOSE ); -#ifdef CONFIG_CODA_FS_OLD_API -memcpy (&(inp->ih.cred), &cred,sizeof (cred)); -#else inp->ih.uid = uid; -#endif - inp->coda_close.VFid = *fid; inp->coda_close.flags = flags;
include/linux/coda.h +0 -43
78 lines not on this page · raw message