Skip to contentSkip to conversation

x86: add save_stack_trace_bp() for tracing from a specific stack frame

PATCH New Vegard Nossum 1 participant 1 message May 20, 2008

Subsystems (2)
x86 x86 stack unwinding
lore
Share & tools
lore

Vegard Nossum

author
#0 lore raw

PATCH 1/1 x86: add save_stack_trace_bp() for tracing from a specific stack frame

Hi Ingo,

I'll put this at the front of the kmemcheck queue. Looks ok?

Vegard

Quoted 1 line

From 03c790cd13efc34c26b9866db46e501dc645faf8 Mon Sep 17 00:00:00 2001

From: Vegard Nossum <[email protected]>
Date: Tue, 20 May 2008 11:15:43 +0200
Subject: [PATCH] x86: add save_stack_trace_bp() for tracing from a specific stack frame

This will help kmemcheck (and possibly other debugging tools) since we can now simply pass regs->bp to the stack tracer instead of specifying the number of stack frames to skip, which is unreliable if gcc decides to inline functions, etc.

Note that this makes the API incomplete for other architectures, but I expect that those can be updated lazily, e.g. when they need it.

Cc Arjan van de Ven <[email protected]>
Signed-off-by Vegard Nossum <[email protected]>
---
 arch/x86/kernel/stacktrace.c |    7 +++++++
 include/linux/stacktrace.h   |    1 +
 2 files changed, 8 insertions(+), 0 deletions(-)
arch/x86/kernel/stacktrace.c +7 -0
index c28c342..97202ad 100644
@@ -75,6 +75,13 @@ void save_stack_trace(struct stack_trace *trace)
 		trace->entries[trace->nr_entries++] = ULONG_MAX;
 }
 
+void save_stack_trace_bp(struct stack_trace *trace, unsigned long bp)
+{
+	dump_trace(current, NULL, NULL, bp, &save_stack_ops, trace);
+	if (trace->nr_entries < trace->max_entries)
+		trace->entries[trace->nr_entries++] = ULONG_MAX;
+}
+
 void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
 {
 	dump_trace(tsk, NULL, NULL, 0, &save_stack_ops_nosched, trace);
include/linux/stacktrace.h +1 -0
index 5da9794..2a3cbe8 100644
@@ -9,6 +9,7 @@ struct stack_trace {
 };
 
 extern void save_stack_trace(struct stack_trace *trace);
+extern void save_stack_trace_bp(struct stack_trace *trace, unsigned long bp);
 extern void save_stack_trace_tsk(struct task_struct *tsk,
 				struct stack_trace *trace);
Signature · 1 line
1.5.4.1