Skip to contentSkip to conversation

Remove gaps and whitespaces in README file

PATCH New Hebbar 2 participants 4 messages May 20, 2008

lore
Share & tools
lore

Hebbar

author
#0 lore raw

PATCH 1/1 Remove gaps and whitespaces in README file

Hi,

Remove gaps and whitespaces in README file

Here in my company i cannot use git and hence no git-patch or git-mail. Will see if i can convince them to allow git. sorry till then

Regards
Gururaja

Signed off by: Gururaja Hebbar <[email protected]>

README +20 -20
diff -purN u-boot-1.3.3/README u-boot-1.3.3-modified/README
@@ -180,15 +180,15 @@ Directory Hierarchy:
 - dtt		Digital Thermometer and Thermostat drivers
 - examples	Example code for standalone applications, etc.
 - include	Header Files
-- lib_arm	Files generic to ARM	 architecture
-- lib_avr32	Files generic to AVR32	 architecture
-- lib_generic	Files generic to all	 architectures
-- lib_i386	Files generic to i386	 architecture
-- lib_m68k	Files generic to m68k	 architecture
-- lib_mips	Files generic to MIPS	 architecture
-- lib_nios	Files generic to NIOS	 architecture
+- lib_arm	Files generic to ARM architecture
+- lib_avr32	Files generic to AVR32 architecture
+- lib_generic	Files generic to all architectures
+- lib_i386	Files generic to i386 architecture
+- lib_m68k	Files generic to m68k architecture
+- lib_mips	Files generic to MIPS architecture
+- lib_nios	Files generic to NIOS architecture
 - lib_ppc	Files generic to PowerPC architecture
-- lib_sparc	Files generic to SPARC	 architecture
+- lib_sparc	Files generic to SPARC architecture
 - libfdt	Library files to support flattened device trees
 - net		Networking code
 - post		Power On Self Test
@@ -608,7 +608,7 @@ The following options need to be configu
 		CONFIG_CMD_NAND		* NAND support
 		CONFIG_CMD_NET		  bootp, tftpboot, rarpboot
 		CONFIG_CMD_PCI		* pciinfo
-		CONFIG_CMD_PCMCIA		* PCMCIA support
+		CONFIG_CMD_PCMCIA	* PCMCIA support
 		CONFIG_CMD_PING		* send ICMP ECHO_REQUEST to network
 					  host
 		CONFIG_CMD_PORTIO	* Port I/O
@@ -618,7 +618,7 @@ The following options need to be configu
 		CONFIG_CMD_SCSI		* SCSI Support
 		CONFIG_CMD_SDRAM	* print SDRAM configuration information
 					  (requires CONFIG_CMD_I2C)
-		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
+		CONFIG_CMD_SETGETDCR  Support for DCR Register access
 					  (4xx only)
 		CONFIG_CMD_SPI		* SPI serial bus support
 		CONFIG_CMD_USB		* USB support
@@ -1697,14 +1697,14 @@ The following options need to be configu
 
 Legacy uImage format:
 
-  Arg	Where			When
+  Arg	Where				When
     1	common/cmd_bootm.c	before attempting to boot an image
-   -1	common/cmd_bootm.c	Image header has bad	 magic number
+   -1	common/cmd_bootm.c	Image header has bad magic number
     2	common/cmd_bootm.c	Image header has correct magic number
-   -2	common/cmd_bootm.c	Image header has bad	 checksum
+   -2	common/cmd_bootm.c	Image header has bad checksum
     3	common/cmd_bootm.c	Image header has correct checksum
-   -3	common/cmd_bootm.c	Image data   has bad	 checksum
-    4	common/cmd_bootm.c	Image data   has correct checksum
+   -3	common/cmd_bootm.c	Image data has bad checksum
+    4	common/cmd_bootm.c	Image data has correct checksum
    -4	common/cmd_bootm.c	Image is for unsupported architecture
     5	common/cmd_bootm.c	Architecture check OK
    -5	common/cmd_bootm.c	Wrong Image Type (not kernel, multi)
@@ -1716,11 +1716,11 @@ Legacy uImage format:
    -9	common/cmd_bootm.c	Unsupported OS (not Linux, BSD, VxWorks, QNX)
 
     9	common/image.c		Start initial ramdisk verification
-  -10	common/image.c		Ramdisk header has bad	   magic number
-  -11	common/image.c		Ramdisk header has bad	   checksum
+  -10	common/image.c		Ramdisk header has bad magic number
+  -11	common/image.c		Ramdisk header has bad checksum
    10	common/image.c		Ramdisk header is OK
-  -12	common/image.c		Ramdisk data   has bad	   checksum
-   11	common/image.c		Ramdisk data   has correct checksum
+  -12	common/image.c		Ramdisk data has bad checksum
+   11	common/image.c		Ramdisk data has correct checksum
    12	common/image.c		Ramdisk verification complete, start loading
   -13	common/image.c		Wrong Image Type (not PPC Linux Ramdisk)
    13	common/image.c		Start multifile image verification
@@ -1762,7 +1762,7 @@ Legacy uImage format:
    48	common/cmd_ide.c	reading Image Header from IDE device OK
   -49	common/cmd_ide.c	Image header has bad magic number
    49	common/cmd_ide.c	Image header has correct magic number
-  -50	common/cmd_ide.c	Image header has bad	 checksum
+  -50	common/cmd_ide.c	Image header has bad checksum
    50	common/cmd_ide.c	Image header has correct checksum
   -51	common/cmd_ide.c	Error reading Image from IDE device
    51	common/cmd_ide.c	reading Image from IDE device OK

http://www.nabble.com/file/p17336468/uboot-1.3.3-README_remove_whitespace.diff
uboot-1.3.3-README_remove_whitespace.diff

Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--Remove-gaps-and-whitespaces-in-README-file-tp17336468p17336468.html
Sent from the Uboot - Users mailing list archive at Nabble.com.
#1 lore raw

PATCH 1/1 Remove gaps and whitespaces in README file

Quoted 2 lines · In message <[email protected]> you wrote:

Remove gaps and whitespaces in README file

Rejected. You corrupt the nice alignment which IMHO makes the code more readable.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If a packet hits a pocket on a socket on a port,
And the bus is interrupted as a very last resort,
And the address of the memory makes your floppy disk abort,
Then the socket packet pocket has an error to report! - Ken Burchill?
author
#2 lore raw

PATCH 1/1 Remove gaps and whitespaces in README file

Quoted 4 lines
Quoted 4 lines

Rejected. You corrupt the nice alignment which IMHO makes the code more

readable.

But few corrections in them doesnt break the alignment like the below ones

@ -608,7 +608,7 @@ The following options need to be configu
CONFIG_CMD_NAND * NAND support
CONFIG_CMD_NET bootp, tftpboot, rarpboot
CONFIG_CMD_PCI * pciinfo
- CONFIG_CMD_PCMCIA * PCMCIA support
+ CONFIG_CMD_PCMCIA * PCMCIA support
CONFIG_CMD_PING * send ICMP ECHO_REQUEST to network
host
CONFIG_CMD_PORTIO * Port I/O
@@ -618,7 +618,7 @@ The following options need to be configu
CONFIG_CMD_SCSI * SCSI Support
CONFIG_CMD_SDRAM * print SDRAM configuration information
(requires CONFIG_CMD_I2C)
- CONFIG_CMD_SETGETDCR Support for DCR Register access
+ CONFIG_CMD_SETGETDCR Support for DCR Register access
(4xx only)
CONFIG_CMD_SPI * SPI serial bus support
CONFIG_CMD_USB * USB support
@@ -1697,14 +1697,14 @@ The following options need to be configu

Legacy uImage format:

- Arg Where When
+ Arg Where When
1 common/cmd_bootm.c before attempting to boot an image
- -1 common/cmd_bootm.c Image header has bad magic number
+ -1 common/cmd_bootm.c Image header has bad magic number
2 common/cmd_bootm.c Image header has correct magic number
- -2 common/cmd_bootm.c Image header has bad checksum
+ -2 common/cmd_bootm.c Image header has bad checksum
3 common/cmd_bootm.c Image header has correct checksum
- -3 common/cmd_bootm.c Image data has bad checksum
- 4 common/cmd_bootm.c Image data has correct checksum
+ -3 common/cmd_bootm.c Image data has bad checksum
+ 4 common/cmd_bootm.c Image data has correct checksum
-4 common/cmd_bootm.c Image is for unsupported architecture
5 common/cmd_bootm.c Architecture check OK
-5 common/cmd_bootm.c Wrong Image Type (not kernel, multi)
@@ -1716,11 +1716,11 @@ Legacy uImage format:
-9 common/cmd_bootm.c Unsupported OS (not Linux, BSD, VxWorks, QNX)

9 common/image.c Start initial ramdisk verification

-  -10	common/image.c		Ramdisk header has bad	   magic number
-  -11	common/image.c		Ramdisk header has bad	   checksum
+  -10	common/image.c		Ramdisk header has bad magic number
+  -11	common/image.c		Ramdisk header has bad checksum

10 common/image.c Ramdisk header is OK
- -12 common/image.c Ramdisk data has bad checksum
- 11 common/image.c Ramdisk data has correct checksum
+ -12 common/image.c Ramdisk data has bad checksum
+ 11 common/image.c Ramdisk data has correct checksum
12 common/image.c Ramdisk verification complete, start loading
-13 common/image.c Wrong Image Type (not PPC Linux Ramdisk)
13 common/image.c Start multifile image verification
@@ -1762,7 +1762,7 @@ Legacy uImage format:
48 common/cmd_ide.c reading Image Header from IDE device OK
-49 common/cmd_ide.c Image header has bad magic number
49 common/cmd_ide.c Image header has correct magic number
- -50 common/cmd_ide.c Image header has bad checksum
+ -50 common/cmd_ide.c Image header has bad checksum
50 common/cmd_ide.c Image header has correct checksum
-51 common/cmd_ide.c Error reading Image from IDE device
51 common/cmd_ide.c reading Image from IDE device OK

Regards
Gururaja

Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--Remove-gaps-and-whitespaces-in-README-file-tp17336468p17336599.html
Sent from the Uboot - Users mailing list archive at Nabble.com.
#3 lore raw

PATCH 1/1 Remove gaps and whitespaces in README file

Quoted 2 lines · In message <[email protected]> you wrote:

But few corrections in them doesnt break the alignment like the below ones

Yes, they do.

README The following options need to be configu · line 611

Quoted 2 lines
README +1 -1
-		CONFIG_CMD_PCMCIA		* PCMCIA support
+		CONFIG_CMD_PCMCIA	* PCMCIA support

This is OK.

README The following options need to be configu · line 621

Quoted 2 lines
README +1 -1
-		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
+		CONFIG_CMD_SETGETDCR  Support for DCR Register access

This is not correct.

README The following options need to be configu · line 1707

Quoted 13 lines
README +5 -5
-  Arg	Where			When
+  Arg	Where				When
     1	common/cmd_bootm.c	before attempting to boot an image
-   -1	common/cmd_bootm.c	Image header has bad	 magic number
+   -1	common/cmd_bootm.c	Image header has bad magic number
     2	common/cmd_bootm.c	Image header has correct magic number
-   -2	common/cmd_bootm.c	Image header has bad	 checksum
+   -2	common/cmd_bootm.c	Image header has bad checksum
     3	common/cmd_bootm.c	Image header has correct checksum
-   -3	common/cmd_bootm.c	Image data   has bad	 checksum
-    4	common/cmd_bootm.c	Image data   has correct checksum
+   -3	common/cmd_bootm.c	Image data has bad checksum
+    4	common/cmd_bootm.c	Image data has correct checksum

And these and the following destroy the intended alignment.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lispers are among  the  best  grads  of  the  Sweep-It-Under-Someone-
Else's-Carpet  School of Simulated Simplicity. [Was that sufficiently
incendiary? :-)]  - Larry Wall in <[email protected]