Skip to contentSkip to conversation

scale down 074 on lower end machines

PATCH In review Christoph Hellwig 3 participants 6 messages May 15, 2008 – Jun 4, 2008

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 scale down 074 on lower end machines

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Signed-off-by Christoph Hellwig <[email protected]>

Index: xfstests/074
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/074,v
retrieving revision 1.7

074 +11 -4
diff -u -p -r1.7 074
@@ -120,10 +120,17 @@ if [ $HOSTOS == "IRIX" ]; then 
         param_type="IRIX nondebug"
     fi
 elif [ $HOSTOS == "Linux" ]; then
-    numloops=10
-    numfiles=5
-    numchildren=3
-    param_type="Linux"
+    if uname -a | grep -q SMP; then
+        numloops=10
+        numfiles=5
+        numchildren=3
+        param_type="Linux SMP"
+    else
+        numloops=2
+        numfiles=3
+        numchildren=3
+        param_type="Linux UP"
+    fi
 else
     numloops=1
     numfiles=1
#1 lore raw
Quoted 5 lines · Christoph Hellwig

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Seems fair - I was wondering exactly the same thing yesterday as this is another test that takes >15min to run on UML. I didn't think of the UP vs SMP trigger, but it seems like a good way to go given all of the real QA boxes we have are SMP.

I'll give it a run and see how it goes.

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
#2 lore raw
Quoted 7 lines · David Chinner
Quoted 5 lines · Christoph Hellwig

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Quoted 6 lines

Seems fair - I was wondering exactly the same thing yesterday as this is another test that takes >15min to run on UML. I didn't think of the UP vs SMP trigger, but it seems like a good way to go given all of the real QA boxes we have are SMP.

I'll give it a run and see how it goes.

FWIW - runtime on UML has dropped from 918s to 88s. Very reasonable now, and makes the maximum single test runtime in UML about 330s....

Cheers,

Dave.

Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
author
#3 lore raw
In reply to Christoph Hellwig

ping?

Quoted 28 lines · Christoph Hellwig

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Signed-off-by Christoph Hellwig <[email protected]>

Index: xfstests/074
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/074,v
retrieving revision 1.7
diff -u -p -r1.7 074

074 +4 -4
@@ -120,10 +120,17 @@ if [ $HOSTOS == "IRIX" ]; then 
         param_type="IRIX nondebug"
     fi
 elif [ $HOSTOS == "Linux" ]; then
-    numloops=10
-    numfiles=5
-    numchildren=3
-    param_type="Linux"
+    if uname -a | grep -q SMP; then
+        numloops=10
+        numfiles=5
+        numchildren=3

074 if [ $HOSTOS == "IRIX" ]; then · line 136

Quoted 10 lines
074 +7 -0
+        param_type="Linux SMP"
+    else
+        numloops=2
+        numfiles=3
+        numchildren=3
+        param_type="Linux UP"
+    fi
 else
     numloops=1
     numfiles=1

---end quoted text---

author
#4 lore raw

ping^2

Quoted 34 lines · Christoph Hellwig

ping?

Quoted 31 lines · Christoph Hellwig

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Signed-off-by Christoph Hellwig <[email protected]>

Index: xfstests/074
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/074,v
retrieving revision 1.7
diff -u -p -r1.7 074

074 +7 -4
@@ -120,10 +120,17 @@ if [ $HOSTOS == "IRIX" ]; then 
         param_type="IRIX nondebug"
     fi
 elif [ $HOSTOS == "Linux" ]; then
-    numloops=10
-    numfiles=5
-    numchildren=3
-    param_type="Linux"
+    if uname -a | grep -q SMP; then
+        numloops=10
+        numfiles=5
+        numchildren=3
+        param_type="Linux SMP"
+    else
+        numloops=2
Quoted 8 lines

074 if [ $HOSTOS == "IRIX" ]; then · line 136

Quoted 7 lines
074 +4 -0
+        numfiles=3
+        numchildren=3
+        param_type="Linux UP"
+    fi
 else
     numloops=1
     numfiles=1

---end quoted text---

---end quoted text---

#5 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig

074 takes ages to complete on my kvm test VM, but scaling it back to the level used on IRIX makes it complete in slightly under 10 minutes.

I'm not sure if checking for UP vs SMP is the right way to go into slow mode, but I couldn't think of anything better.

Looks good enough for now.

Signature · 1 line
Niv Sardi