Skip to contentSkip to conversation

question about drivers/infiniband/core/cm.c's kobject usage

DISCUSSION Greg KH 2 participants 3 messages May 22, 2008

lore
Share & tools
lore

Greg KH

author
#0 lore raw

Hi,

I was working on some changes to the driver core that is cleaning up the struct class fields, when I ran accross the usage of cm.c and the infiniband_cm class.

It looks like you are registering "raw" kobjects in this class, chaining things off of it, as if they were devices.

If so, why not just use struct device in the first place? You are creating a tree, which on modern distros, userspace will never see as they are expecting everything to be showing up in /sys/devices/

Entries in /sys/class/*/* now are symlinks into the /sys/devices tree, showing the representation of everything in one tree, not lots of little trees all over the place.

So I was curious, was this done on purpose? If so, why? If not, any objection to me switching it over to be using struct device properly?

thanks,

greg k-h

#1 lore raw
Quoted 2 lines

So I was curious, was this done on purpose? If so, why? If not, any objection to me switching it over to be using struct device properly?

It's entirely possible I have this wrong, but the intent is to export some infiniband communication management message counters and relate them to the corresponding ib_device/port. For example:

/sys/class/infiniband_cm/<device name>/<port number>/<counter group>/<counter>

(E.g. /sys/class/infiniband_cm/mthca0/1/cm_tx_msgs/req)

If there's a better way to handle this, I have no objection to changing it.

- Sean

author
#2 lore raw
Quoted 7 lines · Sean Hefty
Quoted 2 lines

So I was curious, was this done on purpose? If so, why? If not, any objection to me switching it over to be using struct device properly?

It's entirely possible I have this wrong, but the intent is to export some infiniband communication management message counters and relate them to the corresponding ib_device/port. For example:

Quoted 5 lines

/sys/class/infiniband_cm/<device name>/<port number>/<counter group>/<counter>

(E.g. /sys/class/infiniband_cm/mthca0/1/cm_tx_msgs/req)

If there's a better way to handle this, I have no objection to changing it.

Yes, just hang all of the <port number> stuff off of the original <device name> struct device. That seems like it would be much simpler.

thanks,

greg k-h