Skip to contentSkip to conversation

ipc/sem.c: remove unused entries from struct sem_queue

PATCH In review Manfred Spraul 2 participants 2 messages May 24, 2008 – May 29, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 2/4 ipc/sem.c: remove unused entries from struct sem_queue

sem_queue.sma and sem_queue.id were never used, the attached patch removes them.

---
 include/linux/sem.h |    2 --
 ipc/sem.c           |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
include/linux/sem.h +0 -2
index 6a1af1b..87756ef 100644
@@ -107,8 +107,6 @@ struct sem_queue {
 	struct sem_undo *	undo;	 /* undo structure */
 	int    			pid;	 /* process id of requesting process */
 	int    			status;	 /* completion status of operation */
-	struct sem_array *	sma;	 /* semaphore array for operations */
-	int			id;	 /* internal sem id */
 	struct sembuf *		sops;	 /* array of pending operations */
 	int			nsops;	 /* number of operations */
 	int			alter;   /* does the operation alter the array? */
ipc/sem.c +0 -2
index 211632e..8cd96f1 100644
@@ -1160,12 +1160,10 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
 	 * task into the pending queue and go to sleep.
 	 */
 		
-	queue.sma = sma;
 	queue.sops = sops;
 	queue.nsops = nsops;
 	queue.undo = un;
 	queue.pid = task_tgid_vnr(current);
-	queue.id = semid;
 	queue.alter = alter;
 	if (alter)
 		append_to_queue(sma ,&queue);
Signature · 1 line
1.5.4.1
Reviewed-by on v1 2/4
#1 lore raw
Quoted 4 lines · Manfred Spraul

sem_queue.sma and sem_queue.id were never used, the attached patch removes them.

Quoted 35 lines
---
 include/linux/sem.h |    2 --
 ipc/sem.c           |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
include/linux/sem.h +0 -2
index 6a1af1b..87756ef 100644
@@ -107,8 +107,6 @@ struct sem_queue {
 	struct sem_undo *	undo;	 /* undo structure */
 	int    			pid;	 /* process id of requesting process */
 	int    			status;	 /* completion status of operation */
-	struct sem_array *	sma;	 /* semaphore array for operations */
-	int			id;	 /* internal sem id */
 	struct sembuf *		sops;	 /* array of pending operations */
 	int			nsops;	 /* number of operations */
 	int			alter;   /* does the operation alter the array? */
ipc/sem.c +0 -2
index 211632e..8cd96f1 100644
@@ -1160,12 +1160,10 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
 	 * task into the pending queue and go to sleep.
 	 */
 
-	queue.sma = sma;
 	queue.sops = sops;
 	queue.nsops = nsops;
 	queue.undo = un;
 	queue.pid = task_tgid_vnr(current);
-	queue.id = semid;
 	queue.alter = alter;
 	if (alter)
 		append_to_queue(sma ,&queue);