Skip to contentSkip to conversation

svcrdma: Add flush_scheduled_work to module exit function

PATCH In review Tom Tucker 2 participants 2 messages May 23, 2008 – May 25, 2008 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Tom Tucker

author
#0 lore raw

PATCH 1/1 svcrdma: Add flush_scheduled_work to module exit function

Make certain all transports pending free are flushed from the wq before unloading the module.

---

Thanks to Andrew for pointing this out.

 net/sunrpc/xprtrdma/svc_rdma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/sunrpc/xprtrdma/svc_rdma.c +1 -0
index 88c0ca2..b370e5c 100644
@@ -236,6 +236,7 @@ static ctl_table svcrdma_root_table[] = {
 void svc_rdma_cleanup(void)
 {
 	dprintk("SVCRDMA Module Removed, deregister RPC RDMA transport\n");
+	flush_scheduled_work();
 	if (svcrdma_table_header) {
 		unregister_sysctl_table(svcrdma_table_header);
 		svcrdma_table_header = NULL;

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 3 lines · Tom Tucker

Make certain all transports pending free are flushed from the wq before unloading the module.

OK, makes sense.

--b.

Quoted 22 lines

---

Thanks to Andrew for pointing this out.

 net/sunrpc/xprtrdma/svc_rdma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/sunrpc/xprtrdma/svc_rdma.c +1 -0
index 88c0ca2..b370e5c 100644
@@ -236,6 +236,7 @@ static ctl_table svcrdma_root_table[] = {
 void svc_rdma_cleanup(void)
 {
 	dprintk("SVCRDMA Module Removed, deregister RPC RDMA transport\n");
+	flush_scheduled_work();
 	if (svcrdma_table_header) {
 		unregister_sysctl_table(svcrdma_table_header);
 		svcrdma_table_header = NULL;