streamline init/exit path

PATCH In review Christoph Hellwig 3 participants 10 messages May 18, 2008 – May 25, 2008 XFS filesystem

Share & tools

Christoph Hellwig

author

2008-05-18 13:04 UTC #0 lore raw

PATCH 1/1 streamline init/exit path

Currently the xfs module init/exit code is a mess. It's farmed out over a lot of function with very little error checking. This patch merges xfs_init_zones and xfs_init into init_xfs_fs, and makes sure we propagate all initialization failures properly and clean up after them. Various runtime initializations are replaced with compile-time initializations where possible to make this easier. The exit path is similarly consolidated.

Signed-off-by Christoph Hellwig <[email protected]>

fs/xfs/linux-2.6/xfs_stats.c +12 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_stats.c
===================================================================
@@ -98,12 +98,21 @@ xfs_read_xfsstats(
 	return len;
 }
 
-void
+int
 xfs_init_procfs(void)
 {
 	if (!proc_mkdir("fs/xfs", NULL))
-		return;
-	create_proc_read_entry("fs/xfs/stat", 0, NULL, xfs_read_xfsstats, NULL);
+		goto out;
+
+	if (!create_proc_read_entry("fs/xfs/stat", 0, NULL,
+			xfs_read_xfsstats, NULL))
+		goto out_remove_entry;
+	return 0;
+
+ out_remove_entry:
+	remove_proc_entry("fs/xfs", NULL);
+ out:
+	return -ENOMEM;
 }
 
 void

fs/xfs/linux-2.6/xfs_stats.h +8 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_stats.h
===================================================================
@@ -134,7 +134,7 @@ DECLARE_PER_CPU(struct xfsstats, xfsstat
 #define XFS_STATS_DEC(v)	(per_cpu(xfsstats, current_cpu()).v--)
 #define XFS_STATS_ADD(v, inc)	(per_cpu(xfsstats, current_cpu()).v += (inc))
 
-extern void xfs_init_procfs(void);
+extern int xfs_init_procfs(void);
 extern void xfs_cleanup_procfs(void);

@@ -144,8 +144,13 @@ extern void xfs_cleanup_procfs(void);
 # define XFS_STATS_DEC(count)
 # define XFS_STATS_ADD(count, inc)
 
-static inline void xfs_init_procfs(void) { };
-static inline void xfs_cleanup_procfs(void) { };
+static inline int xfs_init_procfs(void)
+{
+	return 0
+};
+static inline void xfs_cleanup_procfs(void)
+{
+};
 
 #endif	/* !CONFIG_PROC_FS */

fs/xfs/linux-2.6/xfs_super.c +230 ~~-52~~

325 lines not on this page · raw message

fs/xfs/linux-2.6/xfs_sysctl.c +5 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_sysctl.c
===================================================================
@@ -259,15 +259,17 @@ static ctl_table xfs_root_table[] = {
 	{}
 };
 
-void
+int
 xfs_sysctl_register(void)
 {
 	xfs_table_header = register_sysctl_table(xfs_root_table);
+	if (!xfs_table_header)
+		return -ENOMEM;
+	return 0;
 }
 
 void
 xfs_sysctl_unregister(void)
 {
-	if (xfs_table_header)
-		unregister_sysctl_table(xfs_table_header);
+	unregister_sysctl_table(xfs_table_header);
 }

fs/xfs/linux-2.6/xfs_sysctl.h +2 -2

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_sysctl.h
===================================================================
@@ -93,10 +93,10 @@ enum {
 extern xfs_param_t	xfs_params;
 
 #ifdef CONFIG_SYSCTL
-extern void xfs_sysctl_register(void);
+extern int xfs_sysctl_register(void);
 extern void xfs_sysctl_unregister(void);
 #else
-# define xfs_sysctl_register()		do { } while (0)
+# define xfs_sysctl_register()		(0)
 # define xfs_sysctl_unregister()	do { } while (0)
 #endif /* CONFIG_SYSCTL */

fs/xfs/support/uuid.c +1 -7

Index: linux-2.6-xfs/fs/xfs/support/uuid.c
===================================================================
@@ -17,7 +17,7 @@
  */
 #include <xfs.h>
 
-static mutex_t	uuid_monitor;
+static DEFINE_MUTEX(uuid_monitor);
 static int	uuid_table_size;
 static uuid_t	*uuid_table;

@@ -132,9 +132,3 @@ uuid_table_remove(uuid_t *uuid)
 	ASSERT(i < uuid_table_size);
 	mutex_unlock(&uuid_monitor);
 }
-
-void __init
-uuid_init(void)
-{
-	mutex_init(&uuid_monitor);
-}

fs/xfs/support/uuid.h +0 -1

Index: linux-2.6-xfs/fs/xfs/support/uuid.h
===================================================================
@@ -22,7 +22,6 @@ typedef struct {
 	unsigned char	__u_bits[16];
 } uuid_t;
 
-extern void uuid_init(void);
 extern void uuid_create_nil(uuid_t *uuid);
 extern int uuid_is_nil(uuid_t *uuid);
 extern int uuid_equal(uuid_t *uuid1, uuid_t *uuid2);

fs/xfs/xfs_da_btree.c +1 -1

Index: linux-2.6-xfs/fs/xfs/xfs_da_btree.c
===================================================================
@@ -2218,7 +2218,7 @@ xfs_da_state_free(xfs_da_state_t *state)
 
 #ifdef XFS_DABUF_DEBUG
 xfs_dabuf_t	*xfs_dabuf_global_list;
-spinlock_t	xfs_dabuf_global_lock;
+static DEFINE_SPINLOCK(xfs_dabuf_global_lock);
 #endif
 
 /*

fs/xfs/xfs_error.c +0 -8

Index: linux-2.6-xfs/fs/xfs/xfs_error.c
===================================================================
@@ -66,14 +66,6 @@ int	xfs_etest[XFS_NUM_INJECT_ERROR];
 int64_t	xfs_etest_fsid[XFS_NUM_INJECT_ERROR];
 char *	xfs_etest_fsname[XFS_NUM_INJECT_ERROR];
 
-void
-xfs_error_test_init(void)
-{
-	memset(xfs_etest, 0, sizeof(xfs_etest));
-	memset(xfs_etest_fsid, 0, sizeof(xfs_etest_fsid));
-	memset(xfs_etest_fsname, 0, sizeof(xfs_etest_fsname));
-}
-
 int
 xfs_error_test(int error_tag, int *fsidp, char *expression,
 	       int line, char *file, unsigned long randfactor)

fs/xfs/xfs_error.h +0 -1

Index: linux-2.6-xfs/fs/xfs/xfs_error.h
===================================================================
@@ -127,7 +127,6 @@ extern void xfs_corruption_error(char *t
 
 #if (defined(DEBUG) || defined(INDUCE_IO_ERROR))
 extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
-extern void xfs_error_test_init(void);
 
 #define	XFS_NUM_INJECT_ERROR				10

fs/xfs/xfs_filestream.c +3 -1

Index: linux-2.6-xfs/fs/xfs/xfs_filestream.c
===================================================================
@@ -397,10 +397,12 @@ int
 xfs_filestream_init(void)
 {
 	item_zone = kmem_zone_init(sizeof(fstrm_item_t), "fstrm_item");
+	if (!item_zone)
+		return -ENOMEM;
 #ifdef XFS_FILESTREAMS_TRACE
 	xfs_filestreams_trace_buf = ktrace_alloc(XFS_FSTRM_KTRACE_SIZE, KM_SLEEP);
 #endif
-	return item_zone ? 0 : -ENOMEM;
+	return 0;
 }
 
 /*

fs/xfs/xfs_mount.h +0 -3

Index: linux-2.6-xfs/fs/xfs/xfs_mount.h
===================================================================
@@ -543,9 +543,6 @@ extern void	xfs_qmops_put(struct xfs_mou
 
 extern struct xfs_dmops xfs_dmcore_xfs;
 
-extern int	xfs_init(void);
-extern void	xfs_cleanup(void);
-
 #endif	/* __KERNEL__ */
 
 #endif	/* __XFS_MOUNT_H__ */

fs/xfs/xfs_mru_cache.c +8 -5

Index: linux-2.6-xfs/fs/xfs/xfs_mru_cache.c
===================================================================
@@ -307,15 +307,18 @@ xfs_mru_cache_init(void)
 	xfs_mru_elem_zone = kmem_zone_init(sizeof(xfs_mru_cache_elem_t),
 	                                 "xfs_mru_cache_elem");
 	if (!xfs_mru_elem_zone)
-		return ENOMEM;
+		goto out;
 
 	xfs_mru_reap_wq = create_singlethread_workqueue("xfs_mru_cache");
-	if (!xfs_mru_reap_wq) {
-		kmem_zone_destroy(xfs_mru_elem_zone);
-		return ENOMEM;
-	}
+	if (!xfs_mru_reap_wq)
+		goto out_destroy_mru_elem_zone;
 
 	return 0;
+
+ out_destroy_mru_elem_zone:
+	kmem_zone_destroy(xfs_mru_elem_zone);
+ out:
+	return -ENOMEM;
 }
 
 void

fs/xfs/xfs_vfsops.c +0 ~~-131~~

137 lines not on this page · raw message

Niv Sardi

2008-05-21 00:40 UTC #1 lore raw

Quoted 7 lines · Christoph Hellwig

Currently the xfs module init/exit code is a mess. It's farmed out over a lot of function with very little error checking. This patch merges xfs_init_zones and xfs_init into init_xfs_fs, and makes sure we propagate all initialization failures properly and clean up after them. Various runtime initializations are replaced with compile-time initializations where possible to make this easier. The exit path is similarly consolidated.

Looks good, appart from the fact that I don't see the point of merging xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it and making it less readeable.

could be:
error = xfs_init_zones();
if (error)

      goto out;

and all the other error cases will end with
xfs_destroy_zones();

That would look much more like the rest of the calls in these functions.

Signature · 1 line

Niv Sardi

Christoph Hellwig

author

2008-05-21 06:00 UTC #2 lore raw

Quoted 7 lines · Niv Sardi

Looks good, appart from the fact that I don't see the point of merging xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it and making it less readeable.
could be:
error = xfs_init_zones();
if (error)

Quoted 6 lines

      goto out;
and all the other error cases will end with
xfs_destroy_zones();
That would look much more like the rest of the calls in these functions.

I don't really see the point for splitting this up, it's not like it makes the initialization much simpler. But hey, if that's the only objection I can changed it.

At least someone is looking at my xfs patches :)

Niv Sardi

2008-05-21 07:01 UTC #3 lore raw

Quoted 10 lines · Christoph Hellwig

Quoted 9 lines · Niv Sardi
Looks good, appart from the fact that I don't see the point of merging xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it and making it less readeable.
could be:
error = xfs_init_zones();
if (error)
      goto out;

Quoted 8 lines

Quoted 4 lines
and all the other error cases will end with
xfs_destroy_zones();
That would look much more like the rest of the calls in these functions.
I don't really see the point for splitting this up, it's not like it makes the initialization much simpler. But hey, if that's the only objection I can changed it.

it's not splitting it up, just leaving it split up like it was, reduces the function length, reduces the out: gotos, and makes it nicely fit in one editor window =)

Quoted 1 line

At least someone is looking at my xfs patches :)

Cheers =)

Signature · 1 line

Niv Sardi

Christoph Hellwig

author

2008-05-21 07:23 UTC #4 lore raw

Updated patch below. There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also changed the ktrace allocations to KM_MAYFAIL and handled errors resulting from that.

And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..

Signed-off-by Christoph Hellwig <[email protected]>

fs/xfs/linux-2.6/xfs_stats.c +12 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_stats.c
===================================================================
@@ -98,12 +98,21 @@ xfs_read_xfsstats(
 	return len;
 }
 
-void
+int
 xfs_init_procfs(void)
 {
 	if (!proc_mkdir("fs/xfs", NULL))
-		return;
-	create_proc_read_entry("fs/xfs/stat", 0, NULL, xfs_read_xfsstats, NULL);
+		goto out;
+
+	if (!create_proc_read_entry("fs/xfs/stat", 0, NULL,
+			xfs_read_xfsstats, NULL))
+		goto out_remove_entry;
+	return 0;
+
+ out_remove_entry:
+	remove_proc_entry("fs/xfs", NULL);
+ out:
+	return -ENOMEM;
 }
 
 void

fs/xfs/linux-2.6/xfs_stats.h +8 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_stats.h
===================================================================
@@ -134,7 +134,7 @@ DECLARE_PER_CPU(struct xfsstats, xfsstat
 #define XFS_STATS_DEC(v)	(per_cpu(xfsstats, current_cpu()).v--)
 #define XFS_STATS_ADD(v, inc)	(per_cpu(xfsstats, current_cpu()).v += (inc))
 
-extern void xfs_init_procfs(void);
+extern int xfs_init_procfs(void);
 extern void xfs_cleanup_procfs(void);

@@ -144,8 +144,13 @@ extern void xfs_cleanup_procfs(void);
 # define XFS_STATS_DEC(count)
 # define XFS_STATS_ADD(count, inc)
 
-static inline void xfs_init_procfs(void) { };
-static inline void xfs_cleanup_procfs(void) { };
+static inline int xfs_init_procfs(void)
+{
+	return 0
+};
+static inline void xfs_cleanup_procfs(void)
+{
+};
 
 #endif	/* !CONFIG_PROC_FS */

fs/xfs/linux-2.6/xfs_super.c +277 ~~-52~~

374 lines not on this page · raw message

fs/xfs/linux-2.6/xfs_sysctl.c +5 -3

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_sysctl.c
===================================================================
@@ -259,15 +259,17 @@ static ctl_table xfs_root_table[] = {
 	{}
 };
 
-void
+int
 xfs_sysctl_register(void)
 {
 	xfs_table_header = register_sysctl_table(xfs_root_table);
+	if (!xfs_table_header)
+		return -ENOMEM;
+	return 0;
 }
 
 void
 xfs_sysctl_unregister(void)
 {
-	if (xfs_table_header)
-		unregister_sysctl_table(xfs_table_header);
+	unregister_sysctl_table(xfs_table_header);
 }

fs/xfs/linux-2.6/xfs_sysctl.h +2 -2

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_sysctl.h
===================================================================
@@ -93,10 +93,10 @@ enum {
 extern xfs_param_t	xfs_params;
 
 #ifdef CONFIG_SYSCTL
-extern void xfs_sysctl_register(void);
+extern int xfs_sysctl_register(void);
 extern void xfs_sysctl_unregister(void);
 #else
-# define xfs_sysctl_register()		do { } while (0)
+# define xfs_sysctl_register()		(0)
 # define xfs_sysctl_unregister()	do { } while (0)
 #endif /* CONFIG_SYSCTL */

fs/xfs/support/uuid.c +1 -7

Index: linux-2.6-xfs/fs/xfs/support/uuid.c
===================================================================
@@ -17,7 +17,7 @@
  */
 #include <xfs.h>
 
-static mutex_t	uuid_monitor;
+static DEFINE_MUTEX(uuid_monitor);
 static int	uuid_table_size;
 static uuid_t	*uuid_table;

@@ -132,9 +132,3 @@ uuid_table_remove(uuid_t *uuid)
 	ASSERT(i < uuid_table_size);
 	mutex_unlock(&uuid_monitor);
 }
-
-void __init
-uuid_init(void)
-{
-	mutex_init(&uuid_monitor);
-}

fs/xfs/support/uuid.h +0 -1

Index: linux-2.6-xfs/fs/xfs/support/uuid.h
===================================================================
@@ -22,7 +22,6 @@ typedef struct {
 	unsigned char	__u_bits[16];
 } uuid_t;
 
-extern void uuid_init(void);
 extern void uuid_create_nil(uuid_t *uuid);
 extern int uuid_is_nil(uuid_t *uuid);
 extern int uuid_equal(uuid_t *uuid1, uuid_t *uuid2);

fs/xfs/xfs_da_btree.c +1 -1

Index: linux-2.6-xfs/fs/xfs/xfs_da_btree.c
===================================================================
@@ -2218,7 +2218,7 @@ xfs_da_state_free(xfs_da_state_t *state)
 
 #ifdef XFS_DABUF_DEBUG
 xfs_dabuf_t	*xfs_dabuf_global_list;
-spinlock_t	xfs_dabuf_global_lock;
+static DEFINE_SPINLOCK(xfs_dabuf_global_lock);
 #endif
 
 /*

fs/xfs/xfs_error.c +0 -8

Index: linux-2.6-xfs/fs/xfs/xfs_error.c
===================================================================
@@ -66,14 +66,6 @@ int	xfs_etest[XFS_NUM_INJECT_ERROR];
 int64_t	xfs_etest_fsid[XFS_NUM_INJECT_ERROR];
 char *	xfs_etest_fsname[XFS_NUM_INJECT_ERROR];
 
-void
-xfs_error_test_init(void)
-{
-	memset(xfs_etest, 0, sizeof(xfs_etest));
-	memset(xfs_etest_fsid, 0, sizeof(xfs_etest_fsid));
-	memset(xfs_etest_fsname, 0, sizeof(xfs_etest_fsname));
-}
-
 int
 xfs_error_test(int error_tag, int *fsidp, char *expression,
 	       int line, char *file, unsigned long randfactor)

fs/xfs/xfs_error.h +0 -1

Index: linux-2.6-xfs/fs/xfs/xfs_error.h
===================================================================
@@ -127,7 +127,6 @@ extern void xfs_corruption_error(char *t
 
 #if (defined(DEBUG) || defined(INDUCE_IO_ERROR))
 extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
-extern void xfs_error_test_init(void);
 
 #define	XFS_NUM_INJECT_ERROR				10

fs/xfs/xfs_filestream.c +3 -1

Index: linux-2.6-xfs/fs/xfs/xfs_filestream.c
===================================================================
@@ -397,10 +397,12 @@ int
 xfs_filestream_init(void)
 {
 	item_zone = kmem_zone_init(sizeof(fstrm_item_t), "fstrm_item");
+	if (!item_zone)
+		return -ENOMEM;
 #ifdef XFS_FILESTREAMS_TRACE
 	xfs_filestreams_trace_buf = ktrace_alloc(XFS_FSTRM_KTRACE_SIZE, KM_SLEEP);
 #endif
-	return item_zone ? 0 : -ENOMEM;
+	return 0;
 }
 
 /*

fs/xfs/xfs_mount.h +0 -3

Index: linux-2.6-xfs/fs/xfs/xfs_mount.h
===================================================================
@@ -545,9 +545,6 @@ extern void	xfs_qmops_put(struct xfs_mou
 
 extern struct xfs_dmops xfs_dmcore_xfs;
 
-extern int	xfs_init(void);
-extern void	xfs_cleanup(void);
-
 #endif	/* __KERNEL__ */
 
 #endif	/* __XFS_MOUNT_H__ */

fs/xfs/xfs_mru_cache.c +8 -5

Index: linux-2.6-xfs/fs/xfs/xfs_mru_cache.c
===================================================================
@@ -307,15 +307,18 @@ xfs_mru_cache_init(void)
 	xfs_mru_elem_zone = kmem_zone_init(sizeof(xfs_mru_cache_elem_t),
 	                                 "xfs_mru_cache_elem");
 	if (!xfs_mru_elem_zone)
-		return ENOMEM;
+		goto out;
 
 	xfs_mru_reap_wq = create_singlethread_workqueue("xfs_mru_cache");
-	if (!xfs_mru_reap_wq) {
-		kmem_zone_destroy(xfs_mru_elem_zone);
-		return ENOMEM;
-	}
+	if (!xfs_mru_reap_wq)
+		goto out_destroy_mru_elem_zone;
 
 	return 0;
+
+ out_destroy_mru_elem_zone:
+	kmem_zone_destroy(xfs_mru_elem_zone);
+ out:
+	return -ENOMEM;
 }
 
 void

fs/xfs/xfs_vfsops.c +0 ~~-131~~

137 lines not on this page · raw message

Niv Sardi

2008-05-21 08:10 UTC #5 lore raw

TAKE streamline init/exit path

Quoted 6 lines · Christoph Hellwig

Updated patch below. There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also changed the ktrace allocations to KM_MAYFAIL and handled errors resulting from that.
And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..

Thanks,

it's in, forgot to send the TAKE message to oss, here it comes:

Subject: TAKE 976035 - streamline init/exit path

Date:  Wed, 21 May 2008 18:02:18 +1000
Workarea:  chook.melbourne.sgi.com:/build/xaiki/isms/mangrove-1.3
Inspected by:  hch

The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb

Modid: xfs-linux-melb:xfs-kern:31210a

streamline init/exit path

Currently the xfs module init/exit code is a mess. It's farmed out over a lot of function with very little error checking. This patch makes sure we propagate all initialization failures properly and clean up after them. Various runtime initializations are replaced with compile-time initializations where possible to make this easier. The exit path is similarly consolidated.

There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also changed the ktrace allocations to KM_MAYFAIL and handled errors resulting from that.

And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..

Signed-off-by Christoph Hellwig <[email protected]>

Signed-off-by Niv Sardi <[email protected]>

Signature · 1 line

Niv Sardi

Christoph Hellwig

author

2008-05-22 15:55 UTC #6 lore raw

Re: TAKE streamline init/exit path

Quoted 12 lines · Niv Sardi

Quoted 6 lines · Christoph Hellwig
Updated patch below. There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also changed the ktrace allocations to KM_MAYFAIL and handled errors resulting from that.
And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..
Thanks,

Quoted 7 lines

it's in, forgot to send the TAKE message to oss, here it comes:
Subject: TAKE 976035 - streamline init/exit path
Date:  Wed, 21 May 2008 18:02:18 +1000
Workarea:  chook.melbourne.sgi.com:/build/xaiki/isms/mangrove-1.3
Inspected by:  hch

Well, mangrove was the sles10 NAS tree if I remember correctly. And it indeed hasn't made it to either the CVS or git tree on oss.sgi.com yet.

Barry Naujok

2008-05-23 00:25 UTC #7 lore raw

Re: TAKE streamline init/exit path

Quoted 17 lines · Christoph Hellwig

Quoted 16 lines · Niv Sardi
Quoted 2 lines · Christoph Hellwig
Updated patch below. There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also changed
the
Quoted 1 line
ktrace allocations to KM_MAYFAIL and handled errors resulting from
that.
Quoted 3 lines
And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..
Thanks,
it's in, forgot to send the TAKE message to oss, here it comes:

Quoted 8 lines

Quoted 5 lines
Subject: TAKE 976035 - streamline init/exit path
Date:  Wed, 21 May 2008 18:02:18 +1000
Workarea:  chook.melbourne.sgi.com:/build/xaiki/isms/mangrove-1.3
Inspected by:  hch
Well, mangrove was the sles10 NAS tree if I remember correctly. And it indeed hasn't made it to either the CVS or git tree on oss.sgi.com yet.

That's the name of the workarea (and why it's called that... I have no idea!!)

But, the mod did go to the correct location:

Modid: xfs-linux-melb:xfs-kern:31210a

But there is a few hour gap going from Melbourne to the US repository and then to oss.

Barry.

Niv Sardi

2008-05-23 01:57 UTC #8 lore raw

Re: TAKE streamline init/exit path

Quoted 31 lines · Barry Naujok

Quoted 17 lines · Christoph Hellwig
Quoted 16 lines · Niv Sardi
Quoted 2 lines · Christoph Hellwig
Updated patch below. There's now split out function to create/destroy the kmem zones and alloc/free the trace buffers. I've also
changed the
Quoted 1 line
ktrace allocations to KM_MAYFAIL and handled errors resulting
from that.
Quoted 3 lines
And yes, we really should replace the XFS_*_TRACE ifdefs with a single XFS_TRACE..
Thanks,
it's in, forgot to send the TAKE message to oss, here it comes:
Quoted 8 lines
Quoted 5 lines
Subject: TAKE 976035 - streamline init/exit path
Date:  Wed, 21 May 2008 18:02:18 +1000
Workarea:  chook.melbourne.sgi.com:/build/xaiki/isms/mangrove-1.3
Inspected by:  hch
Well, mangrove was the sles10 NAS tree if I remember correctly. And it indeed hasn't made it to either the CVS or git tree on oss.sgi.com yet.
That's the name of the workarea (and why it's called that... I have no idea!!)

Quoted 6 lines

But, the mod did go to the correct location:
Modid: xfs-linux-melb:xfs-kern:31210a
But there is a few hour gap going from Melbourne to the US repository and then to oss.

You really don't want to know how much kittens had to suffer for that TAKE message to be sent out =)

Cheers,

Signature · 1 line

Niv Sardi

Christoph Hellwig

author

2008-05-25 19:09 UTC #9 lore raw

Re: TAKE streamline init/exit path

In reply to Barry Naujok

Quoted 6 lines · Barry Naujok

Quoted 2 lines
Well, mangrove was the sles10 NAS tree if I remember correctly. And it indeed hasn't made it to either the CVS or git tree on oss.sgi.com yet.
That's the name of the workarea (and why it's called that... I have no idea!!)

Quoted 6 lines

But, the mod did go to the correct location:
Modid: xfs-linux-melb:xfs-kern:31210a
But there is a few hour gap going from Melbourne to the US repository and then to oss.

Neither this nor your kmem_free commit have made it yet the CVS tree on oss.sgi.com. I guess the push is broken again for some reason.