Skip to contentSkip to conversation

v4l: fix meaning of tea5767_autodetection

PATCH In review Marcin Slusarz 2 participants 2 messages May 11, 2008 – May 26, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw

PATCH 1/1 v4l: fix meaning of tea5767_autodetection

1) tea5767_autodetection should return negative values on errors
2) tuner_probe should check only for zero/non-zero

Signed-off-by Marcin Slusarz <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>

---
compile tested only

---
 drivers/media/common/tuners/tea5767.c |    6 +++---
 drivers/media/video/tuner-core.c      |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/media/common/tuners/tea5767.c +3 -3
@@ -373,14 +373,14 @@ int tea5767_autodetection(struct i2c_adapter* i2c_adap, u8 i2c_addr)
 
 	if ((rc = tuner_i2c_xfer_recv(&i2c, buffer, 7))< 5) {
 		printk(KERN_WARNING "It is not a TEA5767. Received %i bytes.\n", rc);
-		return EINVAL;
+		return -EINVAL;
 	}
 
 	/* If all bytes are the same then it's a TV tuner and not a tea5767 */
 	if (buffer[0] == buffer[1] && buffer[0] == buffer[2] &&
 	    buffer[0] == buffer[3] && buffer[0] == buffer[4]) {
 		printk(KERN_WARNING "All bytes are equal. It is not a TEA5767\n");
-		return EINVAL;
+		return -EINVAL;
 	}
 
 	/*  Status bytes:

@@ -390,7 +390,7 @@ int tea5767_autodetection(struct i2c_adapter* i2c_adap, u8 i2c_addr)
 	 */
 	if (((buffer[3] & 0x0f) != 0x00) || (buffer[4] != 0x00)) {
 		printk(KERN_WARNING "Chip ID is not zero. It is not a TEA5767\n");
-		return EINVAL;
+		return -EINVAL;
 	}
drivers/media/video/tuner-core.c +1 -1
@@ -1181,7 +1181,7 @@ static int tuner_probe(struct i2c_client *client,
 		case 0x60:
 			if (tuner_symbol_probe(tea5767_autodetection,
 					       t->i2c->adapter, t->i2c->addr)
-					!= EINVAL) {
+					== 0) {
 				t->type = TUNER_TEA5767;
 				t->mode_mask = T_RADIO;
 				t->mode = T_STANDBY;
#1 lore raw

Hi Marcin,

Quoted 2 lines · On Sun, 11 May 2008 21:52:23 +0200 Marcin Slusarz <[email protected]>…

1) tea5767_autodetection should return negative values on errors
2) tuner_probe should check only for zero/non-zero

Thanks. However, a similar patch were already committed at my -git. I suspect that I've already sent it also to mainstream.

Cheers,
Mauro