Skip to contentSkip to conversation

HAVE_CLK (for <linux/clk.h> support)

PATCH David Brownell 4 participants 8 messages May 27, 2008 – Sep 1, 2008 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 3 lines · Felipe Balbi

This patch adds support for MUSB and TUSB controllers integrated into omap2430 and davinci. It also adds support for external tusb6010 controller.

The most significant issue I know of with this patch [0] is actually an arch issue. On ones like x86, with no support for the clock API, this driver will build but not link:

ERROR: "clk_enable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_disable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_put" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_get" [drivers/usb/musb/musb_hdrc.ko] undefined!

I don't know of any other drivers with this particular issue, but nonetheless ... I think the following is an appropriate resolution.

Comments from anyone else?

- Dave

[0] Posted this AM on linux-usb but evidently too big for any of the archives I know about ... 450 KB, which includes host, gadget, and OTG functionality. Previous versions are archived, in the one-file-added-per-patch style.

drivers/usb/musb/Kconfig +1 -1
@@ -8,7 +8,7 @@ comment "Enable Host or Gadget support t
 
 # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
 config USB_MUSB_HDRC
-	depends on USB || USB_GADGET
+	depends on HAVE_CLK && (USB || USB_GADGET)
 	select TWL4030_USB if MACH_OMAP_3430SDP
 	tristate 'Inventra Highspeed Dual Role Controller (TI, ...)'
 	help
arch/Kconfig +3 -0
@@ -39,3 +39,6 @@ config HAVE_KRETPROBES
 
 config HAVE_DMA_ATTRS
 	def_bool n
+
+config HAVE_CLK
+	def_bool n
arch/arm/Kconfig +2 -0
@@ -458,12 +458,14 @@ config ARCH_DAVINCI
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
 	select GENERIC_GPIO
+	select HAVE_CLK
 	help
 	  Support for TI's DaVinci platform.
 
 config ARCH_OMAP
 	bool "TI OMAP"
 	select GENERIC_GPIO
+	select HAVE_CLK
 	select HAVE_GPIO_LIB
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
#3 lore raw

Hi,

Quoted 14 lines · David Brownell
Quoted 3 lines · Felipe Balbi

This patch adds support for MUSB and TUSB controllers integrated into omap2430 and davinci. It also adds support for external tusb6010 controller.

The most significant issue I know of with this patch [0] is actually an arch issue. On ones like x86, with no support for the clock API, this driver will build but not link:

ERROR: "clk_enable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_disable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_put" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_get" [drivers/usb/musb/musb_hdrc.ko] undefined!

Quoted 5 lines

I don't know of any other drivers with this particular issue, but nonetheless ... I think the following is an appropriate resolution.

Comments from anyone else?

I actually like it. I didn't see this error cuz I was only building musb for arm architecture.

But why only davinci and omap?
What about: mach-aaec2000, mach-at91, mach-ep93xx, mach-integrator, mach-lh7a40x, mach-ns9xxx, mach-pnx4008, mach-pxa, mach-realview, mach-sa1100, mach-versatile, mach-s3c24x.

Signature · 4 lines
Best Regards,

Felipe Balbi
[email protected]
#4 lore raw
Quoted 11 lines · Felipe Balbi
Quoted 6 lines

I don't know of any other drivers with this particular issue, but nonetheless ... I think the following is an appropriate resolution.

Comments from anyone else?

I actually like it. I didn't see this error cuz I was only building musb for arm architecture.

But why only davinci and omap?

They're the only one affected by the musb_hdrc patch...

Quoted 3 lines

What about: mach-aaec2000, mach-at91, mach-ep93xx, mach-integrator, mach-lh7a40x, mach-ns9xxx, mach-pnx4008, mach-pxa, mach-realview, mach-sa1100, mach-versatile, mach-s3c24x.

If this approach goes forward, I'd expect those platforms to "select HAVE_CLK" too. Ditto some SH, PowerPC, etc.

Quoted 3 lines

Instead of making the driver dependant on HAVE_CLK (which would be true for virtually any driver comming from linux-omap), you could make clk_enable a nop in case arch doesn't HAVE_CLK. How does that sound?

Best done by #ifdef HAVE_CLK in <linux/clk.h> support, and putting the stubs there. However, since those platforms don't actually have clocks, I'd make them all report errors of whichever kind.

That's kind of a second-order question to "should we create a HAVE_CLK in Kconfig". Since Certain People have objected to patches touching <linux/clk.h> I avoided doing that the first time around ... it'd be a better solution, yes.

- Dave

#5 lore raw

Sorry for jumping in so later. I noticed Blackfin does not support HAVE_CLK currently.
As the HAVE_CLK dependence is included in the kernel mainline, MUSB parts do not show up in the Kconfig because of lacking of HAVE_CLK.

To implement clk infrastructure in Blackfin will be later than merging MUSB Blackfin parts to upstream.

Any idea?

Thanks
-Bryan

Quoted 45 lines · David Brownell
Quoted 11 lines · Felipe Balbi
Quoted 6 lines

I don't know of any other drivers with this particular issue, but nonetheless ... I think the following is an appropriate resolution.

Comments from anyone else?

I actually like it. I didn't see this error cuz I was only building musb for arm architecture.

But why only davinci and omap?

They're the only one affected by the musb_hdrc patch...

Quoted 3 lines

What about: mach-aaec2000, mach-at91, mach-ep93xx, mach-integrator, mach-lh7a40x, mach-ns9xxx, mach-pnx4008, mach-pxa, mach-realview, mach-sa1100, mach-versatile, mach-s3c24x.

If this approach goes forward, I'd expect those platforms to "select HAVE_CLK" too. Ditto some SH, PowerPC, etc.

Quoted 3 lines

Instead of making the driver dependant on HAVE_CLK (which would be true for virtually any driver comming from linux-omap), you could make clk_enable a nop in case arch doesn't HAVE_CLK. How does that sound?

Best done by #ifdef HAVE_CLK in <linux/clk.h> support, and putting the stubs there. However, since those platforms don't actually have clocks, I'd make them all report errors of whichever kind.

That's kind of a second-order question to "should we create a HAVE_CLK in Kconfig". Since Certain People have objected to patches touching <linux/clk.h> I avoided doing that the first time around ... it'd be a better solution, yes.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
Quoted 9 lines · ext Bryan Wu

Sorry for jumping in so later. I noticed Blackfin does not support HAVE_CLK currently.
As the HAVE_CLK dependence is included in the kernel mainline, MUSB parts do not show up in the Kconfig because of lacking of HAVE_CLK.

To implement clk infrastructure in Blackfin will be later than merging MUSB Blackfin parts to upstream.

Any idea?

dude, you're really late on this one. Now that musb depends on HAVE_CLK and we have things working for that. What you can do is locally (on your tree) remove the HAVE_CLK dependency so you can keep musb development going. But don't push that patch upstream. Meanwhile, you'll have time to implement clk framework support for blackfin.

Signature · 1 line
balbi
#7 lore raw
Quoted 9 lines · Felipe Balbi
Quoted 8 lines · ext Bryan Wu

Sorry for jumping in so later. I noticed Blackfin does not support HAVE_CLK currently.
As the HAVE_CLK dependence is included in the kernel mainline, MUSB parts do not show up in the Kconfig because of lacking of HAVE_CLK.

To implement clk infrastructure in Blackfin will be later than merging MUSB Blackfin parts to upstream.

Quoted 8 lines
Quoted 1 line

Any idea?

dude, you're really late on this one. Now that musb depends on HAVE_CLK and we have things working for that. What you can do is locally (on your tree) remove the HAVE_CLK dependency so you can keep musb development going. But don't push that patch upstream. Meanwhile, you'll have time to implement clk framework support for blackfin.

Too bad, I just realize this when I try to port my local blackfin patch for upstream merge.
You're right, currently I remove the dependency locally. So I need to add a new task to implement clk framework for Blackfin.

OK, another question, do you know where is the latest usb development git tree, buddy?

Thanks
-Bryan

#8 lore raw
Quoted 19 lines · ext Bryan Wu
Quoted 9 lines · Felipe Balbi
Quoted 8 lines · ext Bryan Wu

Sorry for jumping in so later. I noticed Blackfin does not support HAVE_CLK currently.
As the HAVE_CLK dependence is included in the kernel mainline, MUSB parts do not show up in the Kconfig because of lacking of HAVE_CLK.

To implement clk infrastructure in Blackfin will be later than merging MUSB Blackfin parts to upstream.

Quoted 8 lines
Quoted 1 line

Any idea?

dude, you're really late on this one. Now that musb depends on HAVE_CLK and we have things working for that. What you can do is locally (on your tree) remove the HAVE_CLK dependency so you can keep musb development going. But don't push that patch upstream. Meanwhile, you'll have time to implement clk framework support for blackfin.

Quoted 7 lines

Too bad, I just realize this when I try to port my local blackfin patch for upstream merge.
You're right, currently I remove the dependency locally. So I need to add a new task to implement clk framework for Blackfin.

OK, another question, do you know where is the latest usb development git tree, buddy?

I replied on the other mail :-)

It's a quilt tree on kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/

Just take a look at MAINTAINERS file ;-)

Signature · 1 line
balbi
#9 lore raw
In reply to David Brownell

On Wed, May 28, 2008 at 2:14 AM, David Brownell <[email protected]> wrote:

[snip]

drivers/usb/musb/Kconfig 2008-05-27 16:01:09.000000000 -0700 comment "Enable Host or Gadget support t · line 14

Quoted 11 lines
drivers/usb/musb/Kconfig 2008-05-27 16:01:09.000000000 -0700 renamed from drivers/usb/musb/Kconfig 2008-05-27 16:02:41.000000000 -0700 +1 -1
@@ -8,7 +8,7 @@ comment "Enable Host or Gadget support t
 
 # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
 config USB_MUSB_HDRC
-       depends on USB || USB_GADGET
+       depends on HAVE_CLK && (USB || USB_GADGET)
       select TWL4030_USB if MACH_OMAP_3430SDP
       tristate 'Inventra Highspeed Dual Role Controller (TI, ...)'
       help

Sorry, another comment.

Instead of making the driver dependant on HAVE_CLK (which would be true for virtually any driver comming from linux-omap), you could make clk_enable a nop in case arch doesn't HAVE_CLK. How does that sound?

Signature · 4 lines
Best Regards,

Felipe Balbi
[email protected]