fix reiserfs case in 032
PATCH 1/1 fix reiserfs case in 032
mkfs.reiserfs refuses to create a filesystem on full devices without partitions unless it's given -f in addition to the already required Y input to confirm the fs creation, so give the argument to it.
While we're at it also write the full command line used to create the filesystem into the log to ease future debugging.
Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.13
032 +2 -2
@@ -43,7 +43,7 @@ do [ $fs = vfat ] && postargs=2000 # these folks prompt before writing [ $fs = jfs ] && preop="echo Y |" - [ $fs = reiserfs ] && preop="echo y |" + [ $fs = reiserfs ] && preop="echo y |" && preargs="-f" # cramfs mkfs requires a directory argument [ $fs = cramfs ] && preargs=/proc/fs/xfs
@@ -52,7 +52,7 @@ do # create a filesystem of this type echo "=== Creating $fs filesystem..." >>$seq.full - echo " ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full + echo " ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1 # next, ensure we don't overwrite it
ping?
Quoted 27 lines · Christoph Hellwig
mkfs.reiserfs refuses to create a filesystem on full devices without partitions unless it's given -f in addition to the already required Y input to confirm the fs creation, so give the argument to it.
While we're at it also write the full command line used to create the filesystem into the log to ease future debugging.
Signed-off-by Christoph Hellwig <[email protected]>Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.13
diff -u -p -r1.13 032032 +1
-1@@ -43,7 +43,7 @@ do [ $fs = vfat ] && postargs=2000 # these folks prompt before writing [ $fs = jfs ] && preop="echo Y |" - [ $fs = reiserfs ] && preop="echo y |" + [ $fs = reiserfs ] && preop="echo y |" && preargs="-f" # cramfs mkfs requires a directory argument [ $fs = cramfs ] && preargs=/proc/fs/xfs
032 do · line 58
Quoted 8 lines
032 +1
-1@@ -52,7 +52,7 @@ do # create a filesystem of this type echo "=== Creating $fs filesystem..." >>$seq.full - echo " ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full + echo " ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1 # next, ensure we don't overwrite it
---end quoted text---
Can we get a least a trivial testsuite fix like this reviewed an in?
Quoted 27 lines · Christoph Hellwig
mkfs.reiserfs refuses to create a filesystem on full devices without partitions unless it's given -f in addition to the already required Y input to confirm the fs creation, so give the argument to it.
While we're at it also write the full command line used to create the filesystem into the log to ease future debugging.
Signed-off-by Christoph Hellwig <[email protected]>Index: xfstests/032
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/032,v
retrieving revision 1.13
diff -u -p -r1.13 032032 +1
-1@@ -43,7 +43,7 @@ do [ $fs = vfat ] && postargs=2000 # these folks prompt before writing [ $fs = jfs ] && preop="echo Y |" - [ $fs = reiserfs ] && preop="echo y |" + [ $fs = reiserfs ] && preop="echo y |" && preargs="-f" # cramfs mkfs requires a directory argument [ $fs = cramfs ] && preargs=/proc/fs/xfs
032 do · line 58
Quoted 8 lines
032 +1
-1@@ -52,7 +52,7 @@ do # create a filesystem of this type echo "=== Creating $fs filesystem..." >>$seq.full - echo " ( mkfs -t $fs $SCRATCH_DEV )" >>$seq.full + echo " ( $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs )" >>$seq.full eval $preop mkfs -t $fs $preargs $SCRATCH_DEV $postargs >>$seq.full 2>&1 # next, ensure we don't overwrite it
---end quoted text---