scsi/arm: check the return value of device_create_file() in powertec.c

PATCH New Qinghuang Feng 1 participant 1 message May 28, 2008

Subsystems (2)

SCSI Arm/riscpc architecture

lore

Share & tools

lore

Qinghuang Feng

author

2008-05-28 18:11 UTC #0 lore raw

PATCH 1/1 scsi/arm: check the return value of device_create_file() in powertec.c

powertec.c : add code to print an error message while device_create_file() called from powertecscsi_probe() fail

Signed-off-by Qinghuang Feng <[email protected]>

---

drivers/scsi/arm/powertec.c +6 -2

index d9a546d..14e25a6 100644
@@ -315,6 +315,7 @@ powertecscsi_probe(struct expansion_card
 	struct powertec_info *info;
 	void __iomem *base;
 	int ret;
+	int ferr;
 
 	ret = ecard_request_resources(ec);
 	if (ret)

@@ -361,7 +362,9 @@ powertecscsi_probe(struct expansion_card
 
 	ecard_setirq(ec, &powertecscsi_ops, info);
 
-	device_create_file(&ec->dev, &dev_attr_bus_term);
+	ferr = device_create_file(&ec->dev, &dev_attr_bus_term);
+	if (ferr)
+		printk(KERN_ERR "powertecscsi :failed to create the attribute file !\n");
 
 	ret = fas216_init(host);
 	if (ret)

@@ -398,7 +401,8 @@ powertecscsi_probe(struct expansion_card
 	fas216_release(host);
 
  out_free:
-	device_remove_file(&ec->dev, &dev_attr_bus_term);
+	if (!ferr)
+		device_remove_file(&ec->dev, &dev_attr_bus_term);
 	scsi_host_put(host);
 
  out_region: