Skip to contentSkip to conversation

sysctl: check for bogus modes

PATCH New Alexey Dobriyan 1 participant 1 message May 29, 2008 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysctl: check for bogus modes

Catch, e. g., 644/0644 typo.

---

 kernel/sysctl_check.c |    2 ++
 1 file changed, 2 insertions(+)
kernel/sysctl_check.c +2 -0
@@ -1532,6 +1532,8 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
 			sysctl_check_leaf(namespaces, table, &fail);
 		}
 		sysctl_check_bin_path(table, &fail);
+		if (table->mode > 0777)
+			set_fail(&fail, table, "bogus .mode");
 		if (fail) {
 			set_fail(&fail, table, NULL);
 			error = -EINVAL;