Skip to contentSkip to conversation

sfc: Report XAUI link down at default log level

PATCH Applied Ben Hutchings 2 participants 2 messages May 30, 2008 – May 31, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 1/1 sfc: Report XAUI link down at default log level

This is normal when the external link is down so don't report it as an error.

Signed-off-by Ben Hutchings <[email protected]>
---
 drivers/net/sfc/falcon_xmac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/sfc/falcon_xmac.c +1 -1
index 264e1ee..37d3cae 100644
@@ -513,7 +513,7 @@ static int falcon_check_xaui_link_up(struct efx_nic *efx)
 		tries--;
 	}
 
-	EFX_ERR(efx, "Failed to bring XAUI link back up in %d tries!\n",
+	EFX_LOG(efx, "Failed to bring XAUI link back up in %d tries!\n",
 		max_tries);
 	return 0;
 }
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
Applied
#1 lore raw
Quoted 12 lines · Ben Hutchings

This is normal when the external link is down so don't report it as an error.

Signed-off-by Ben Hutchings <[email protected]>
---
 drivers/net/sfc/falcon_xmac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/sfc/falcon_xmac.c +0 -0
index 264e1ee..37d3cae 100644

drivers/net/sfc/falcon_xmac.c static int falcon_check_xaui_link_up(struct efx_nic *efx) · line 517

Quoted 6 lines
drivers/net/sfc/falcon_xmac.c +1 -1
@@ -513,7 +513,7 @@ static int falcon_check_xaui_link_up(struct efx_nic *efx)
 		tries--;
 	}
 
-	EFX_ERR(efx, "Failed to bring XAUI link back up in %d tries!\n",
+	EFX_LOG(efx, "Failed to bring XAUI link back up in %d tries!\n",
 		max_tries);

applied