Skip to contentSkip to conversation

ide-generic: add missing hwif->chipset setup

PATCH New Bartlomiej Zolnierkiewicz 1 participant 1 message May 31, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide-generic: add missing hwif->chipset setup

hwif->chipset need to be set properly or ide-generic driver will break once we make a final step in fixing host drivers' dependence on ide_hwifs[].

Problem was catched early thanks to IDE tree exposure in -mm / -next trees and reported by people listed people (thank you guys!).

---
With this patch applied we can bring "ide: fix hwif-s initialization" and "ide: make ide_hwifs[] static" patches back into IDE tree! :)

 drivers/ide/ide-generic.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ide/ide-generic.c +1 -0
Index: b/drivers/ide/ide-generic.c
===================================================================
@@ -125,6 +125,7 @@ static int __init ide_generic_init(void)
 			memset(&hw, 0, sizeof(hw));
 			ide_std_init_ports(&hw, io_addr, io_addr + 0x206);
 			hw.irq = ide_default_irq(io_addr);
+			hw.chipset = ide_generic;
 			ide_init_port_hw(hwif, &hw);
 
 			idx[i] = i;