Skip to contentSkip to conversation

Why is the rewritten ramdisk driver called brd instad of rd

DISCUSSION Christoph Hellwig 4 participants 5 messages Mar 21, 2008 – Jun 4, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Any reason why the rewritten ramdisk driver has a new name? It's for all matters an inplace replacement of the old rd driver so it should be called rd.c / rd.ko to not confused instaler/developers/etc.

#1 lore raw
Quoted 3 lines · Christoph Hellwig

Any reason why the rewritten ramdisk driver has a new name? It's for all matters an inplace replacement of the old rd driver so it should be called rd.c / rd.ko to not confused instaler/developers/etc.

I think it's because the old rd played some dirty tricks with the page cache, while the reworked one is a straightforward implementation of a normal _b_lock device -> hence the "b".

No guarantee of correctness.

Petr Tesarik

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 10 lines · Petr Tesarik
Quoted 3 lines · Christoph Hellwig

Any reason why the rewritten ramdisk driver has a new name? It's for all matters an inplace replacement of the old rd driver so it should be called rd.c / rd.ko to not confused instaler/developers/etc.

I think it's because the old rd played some dirty tricks with the page cache, while the reworked one is a straightforward implementation of a normal _b_lock device -> hence the "b".

No guarantee of correctness.

Yeah it was a rwrite from scratch and it lived with the rd.c code for a while (although maybe never in mainline). I guess it might be good idea to rename it back to rd?

#3 lore raw
Quoted 10 lines · Nick Piggin
Quoted 9 lines · Petr Tesarik
Quoted 3 lines · Christoph Hellwig

Any reason why the rewritten ramdisk driver has a new name? It's for all matters an inplace replacement of the old rd driver so it should be called rd.c / rd.ko to not confused instaler/developers/etc.

I think it's because the old rd played some dirty tricks with the page cache, while the reworked one is a straightforward implementation of a normal _b_lock device -> hence the "b".

Quoted 5 lines
Quoted 1 line

No guarantee of correctness.

Yeah it was a rwrite from scratch and it lived with the rd.c code for a while (although maybe never in mainline). I guess it might be good idea to rename it back to rd?

Just add a MODULE_ALIAS("rd").

#4 lore raw
Quoted 13 lines · Jan Engelhardt
Quoted 10 lines · Nick Piggin
Quoted 9 lines · Petr Tesarik
Quoted 3 lines · Christoph Hellwig

Any reason why the rewritten ramdisk driver has a new name? It's for all matters an inplace replacement of the old rd driver so it should be called rd.c / rd.ko to not confused instaler/developers/etc.

I think it's because the old rd played some dirty tricks with the page cache, while the reworked one is a straightforward implementation of a normal _b_lock device -> hence the "b".

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

No guarantee of correctness.

Yeah it was a rwrite from scratch and it lived with the rd.c code for a while (although maybe never in mainline). I guess it might be good idea to rename it back to rd?

Just add a MODULE_ALIAS("rd").

Couldn't hurt... shall we merge this, then?

Alias brd to rd in the hope of helping legacy users. Suggested by Jan.

---

drivers/block/brd.c +1 -0
Index: linux-2.6/drivers/block/brd.c
===================================================================
@@ -397,6 +397,7 @@ module_param(max_part, int, 0);
 MODULE_PARM_DESC(max_part, "Maximum number of partitions per RAM disk");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_BLOCKDEV_MAJOR(RAMDISK_MAJOR);
+MODULE_ALIAS("rd");
 
 #ifndef MODULE
 /* Legacy boot options - nonmodular */