Skip to contentSkip to conversation

cifs: primitive is not an asn1 class

PATCH New Chris Wright 1 participant 1 message Jun 4, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: primitive is not an asn1 class

When verifying the decoded header before decoding the object identifier (expecting a SPNEGO pseudo-mechanism oid), the test to verify it is a primitive encoding is compared against the asn1 class. Primitive is not a class. This brings check in line with similar check for krb/ntlmssp oid.

---
 fs/cifs/asn1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/cifs/asn1.c +1 -1
index cb52cbb..49be2ed 100644
@@ -480,7 +480,7 @@ decode_negTokenInit(unsigned char *security_blob, int length,
 		/*      remember to free obj->oid */
 		rc = asn1_header_decode(&ctx, &end, &cls, &con, &tag);
 		if (rc) {
-			if ((tag == ASN1_OJI) && (cls == ASN1_PRI)) {
+			if ((tag == ASN1_OJI) && (con == ASN1_PRI)) {
 				rc = asn1_oid_decode(&ctx, end, &oid, &oidlen);
 				if (rc) {
 					rc = compare_oid(oid, oidlen,