Skip to contentSkip to conversation

MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove

PATCH In review Anton Vorontsov 2 participants 2 messages Jun 6, 2008

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 1/1 MTD: NAND: fsl_elbc_nand: fix section mismatch between probe and remove

WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch in reference from the function fsl_elbc_ctrl_probe() to the function .devexit.text:fsl_elbc_ctrl_remove()

__devinit functions should not call functions with __devexit. Since probe function calls remove in case of errors, we want to remove __devexit attribute from it.

Signed-off-by Anton Vorontsov <[email protected]>
---
 drivers/mtd/nand/fsl_elbc_nand.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/fsl_elbc_nand.c +2 -2
index 4b69aac..1b06d29 100644
@@ -917,7 +917,7 @@ static int __devinit fsl_elbc_ctrl_init(struct fsl_elbc_ctrl *ctrl)
 	return 0;
 }
 
-static int __devexit fsl_elbc_ctrl_remove(struct of_device *ofdev)
+static int fsl_elbc_ctrl_remove(struct of_device *ofdev)
 {
 	struct fsl_elbc_ctrl *ctrl = dev_get_drvdata(&ofdev->dev);
 	int i;

@@ -1041,7 +1041,7 @@ static struct of_platform_driver fsl_elbc_ctrl_driver = {
 	},
 	.match_table = fsl_elbc_match,
 	.probe = fsl_elbc_ctrl_probe,
-	.remove = __devexit_p(fsl_elbc_ctrl_remove),
+	.remove = fsl_elbc_ctrl_remove,
 };
 
 static int __init fsl_elbc_init(void)
Signature · 1 line
1.5.5.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Anton Vorontsov

WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch in reference from the function fsl_elbc_ctrl_probe() to the function .devexit.text:fsl_elbc_ctrl_remove()

__devinit functions should not call functions with __devexit. Since probe function calls remove in case of errors, we want to remove __devexit attribute from it.

Signed-off-by Anton Vorontsov <[email protected]>
Acked-by Scott Wood <[email protected]>

-Scott