lm75: sensor reading bugfix

LM75 sensor reading bugfix: never save error status as valid sensor output. This could be improved, but at least this prevents certain rude failure modes.

Signed-off-by David Brownell <[email protected]>

---
Goes on top of the previously submitted lm75 cleanup patch:

	http://marc.info/?l=lm-sensors&m0880547009929&w=2

 drivers/hwmon/lm75.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

drivers/hwmon/lm75.c +8 -5

@@ -259,10 +259,13 @@ static struct i2c_driver lm75_driver = {
    the SMBus standard. */
 static int lm75_read_value(struct i2c_client *client, u8 reg)
 {
+	int value;
+
 	if (reg = LM75_REG_CONF)
 		return i2c_smbus_read_byte_data(client, reg);
-	else
-		return swab16(i2c_smbus_read_word_data(client, reg));
+
+	value = i2c_smbus_read_word_data(client, reg);
+	return (value < 0) ? value : swab16(value);
 }
 
 static int lm75_write_value(struct i2c_client *client, u8 reg, u16 value)

@@ -295,9 +298,16 @@ static struct lm75_data *lm75_update_dev
 		int i;
 		dev_dbg(&client->dev, "Starting lm75 update\n");
 
-		for (i = 0; i < ARRAY_SIZE(data->temp); i++)
-			data->temp[i] = lm75_read_value(client,
-							LM75_REG_TEMP[i]);
+		for (i = 0; i < ARRAY_SIZE(data->temp); i++) {
+			int status;
+

LM75 sensor reading bugfix: never save error status as valid sensor output. This could be improved, but at least this prevents certain rude failure modes.

Signed-off-by David Brownell <[email protected]>

---
Goes on top of the previously submitted lm75 cleanup patch:

	http://marc.info/?l=lm-sensors&m0880547009929&w=2

 drivers/hwmon/lm75.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

Hi David:

Quoted 4 lines · David Brownell

LM75 sensor reading bugfix: never save error status as valid sensor output. This could be improved, but at least this prevents certain rude failure modes.

Quoted 8 lines

Signed-off-by David Brownell <[email protected]>

---
Goes on top of the previously submitted lm75 cleanup patch:

	http://marc.info/?l=lm-sensors&m0880547009929&w=2

 drivers/hwmon/lm75.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

Applied to hwmon-2.6.git/testing, thanks.

Hrm, I missed this one on the first pass through my queue when I picked up your other lm75 patches. Looks like it's severe enough to warrant sending to Linus before 2.6.26 (along with the prerequisite cleanup patch).

Any objections?

Applied to hwmon-2.6.git/testing, thanks.

Hrm, I missed this one on the first pass through my queue when I picked up your other lm75 patches.  Looks like it's severe enough to warrant sending to Linus before 2.6.26 (along with the prerequisite cleanup patch).

Any objections?