Skip to contentSkip to conversation

sched: Kill off dead cfs_rq_set_shares().

PATCH Applied Paul Mundt 2 participants 2 messages Jun 9, 2008 – Jun 10, 2008

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 sched: Kill off dead cfs_rq_set_shares().

Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused cfs_rq_set_shares() reference. As nothing is using this dummy function in the first place, just kill it off.

Against current git, but still seems to be relevant to 'sched-devel' in -tip.

Signed-off-by Paul Mundt <[email protected]>

---

 kernel/sched.c |    8 --------
 1 file changed, 8 deletions(-)
kernel/sched.c +0 -8
index bfb8ad8..25de9ef 100644
@@ -1471,16 +1471,8 @@ static unsigned long source_load(int cpu, int type);
 static unsigned long target_load(int cpu, int type);
 static unsigned long cpu_avg_load_per_task(int cpu);
 static int task_hot(struct task_struct *p, u64 now, struct sched_domain *sd);
-#else /* CONFIG_SMP */
-
-#ifdef CONFIG_FAIR_GROUP_SCHED
-static void cfs_rq_set_shares(struct cfs_rq *cfs_rq, unsigned long shares)
-{
-}
 #endif
 
-#endif /* CONFIG_SMP */
-
 #include "sched_stats.h"
 #include "sched_idletask.c"
 #include "sched_fair.c"
Applied
#1 lore raw
Quoted 6 lines · Paul Mundt

Building with CONFIG_FAIR_GROUP_SCHED=y on UP results in an unused cfs_rq_set_shares() reference. As nothing is using this dummy function in the first place, just kill it off.

Against current git, but still seems to be relevant to 'sched-devel' in -tip.

applied, thanks Paul.

Ingo