Skip to contentSkip to conversation

sfc: Recover from RX queue flush failure

PATCH Applied Ben Hutchings 2 participants 2 messages Jun 9, 2008 – Jun 10, 2008 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 sfc: Recover from RX queue flush failure

From: Steve Hodgson <[email protected]>

RX queue flush can fail if traffic continues to arrive. Recover by performing an invisible reset.

---
 drivers/net/sfc/falcon.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/net/sfc/falcon.c +3 -1
index cbe2e83..f2d361f 100644
@@ -842,8 +842,10 @@ void falcon_fini_rx(struct efx_rx_queue *rx_queue)
 			continue;
 		break;
 	}
-	if (rc)
+	if (rc) {
 		EFX_ERR(efx, "failed to flush rx queue %d\n", rx_queue->queue);
+		efx_schedule_reset(efx, RESET_TYPE_INVISIBLE);
+	}
 
 	/* Remove RX descriptor ring from card */
 	EFX_ZERO_OWORD(rx_desc_ptr);
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
Applied
#2 lore raw
Quoted 9 lines · Ben Hutchings

From: Steve Hodgson <[email protected]>

RX queue flush can fail if traffic continues to arrive. Recover by performing an invisible reset.

---
 drivers/net/sfc/falcon.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

applied