lm75: cleanup/reorg
PATCH 1/1 lm75: cleanup/reorg
Minor cleanup and reorg of the lm75 code.
- Kconfig provides a larger list of lm75-compatible chips
- A top comment now says what the driver does (!) ... as in, just what sort of sensor is this??
- Section comments now delineate the various sections of the driver:
hwmon attributes, driver binding, register access, module glue. One driver binding function moved out of the attribute section, as did the driver struct itself.
- Minor tweaks to legacy probe logic: correct a comment, and remove a pointless variable.
- Whitespace, linelength, and comment fixes.
This patch should include no functional changes. It's preparation for adding new-style (driver model) I2C driver binding.
--- drivers/hwmon/Kconfig | 20 +++++++---- drivers/hwmon/lm75.c | 90 ++++++++++++++++++++++++++++---------------------- 2 files changed, 64 insertions(+), 46 deletions(-)
drivers/hwmon/Kconfig +13 -7
@@ -380,13 +380,19 @@ config SENSORS_LM75 tristate "National Semiconductor LM75 and compatibles" depends on I2C help - If you say yes here you get support for National Semiconductor LM75 - sensor chips and clones: Dallas Semiconductor DS75 and DS1775 (in - 9-bit precision mode), and TelCom (now Microchip) TCN75. - - The DS75 and DS1775 in 10- to 12-bit precision modes will require - a force module parameter. The driver will not handle the extra - precision anyhow. + If you say yes here you get support for one common type of + temperature sensor chip, with models including: + + - Dallas Semiconductor DS75 and DS1775 + - Maxim MAX6625 and MAX6626 + - Microchip MCP980x + - National Semiconductor LM75 + - NXP's LM75A + - ST Microelectronics STDS75 + - TelCom (now Microchip) TCN75 + - Texas Instruments TMP100, TMP101, TMP75, TMP175, TMP275 + + Most of these chips will require a "force" module parameter. This driver can also be built as a module. If so, the module will be called lm75.
drivers/hwmon/lm75.c +51 -39
189 lines not on this page · raw message
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 28 lines · David Brownell
Minor cleanup and reorg of the lm75 code.
-
Kconfigprovides a larger list of lm75-compatible chips- A top comment now says what the driver does (!) ... as in, just what sort of sensor is this??
- Section comments now delineate the various sections of the driver:
hwmon attributes, driver binding, register access, module glue. One driver binding function moved out of the attribute section, as did the driver struct itself.- Minor tweaks to legacy probe logic: correct a comment, and remove a pointless variable.
- Whitespace, linelength, and comment fixes.
This patch should include no functional changes. It's preparation for adding new-style (driver model) I2C driver binding.
Signed-off-by David Brownell <[email protected]>Acked-by Jean Delvare <[email protected]>Acked-by Laurent Pinchart <[email protected]>--- drivers/hwmon/Kconfig | 20 +++++++---- drivers/hwmon/lm75.c | 90 ++++++++++++++++++++++++++++---------------------- 2 files changed, 64 insertions(+), 46 deletions(-)
<snip>
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi David:
Quoted 20 lines · David Brownell
Minor cleanup and reorg of the lm75 code.
-
Kconfigprovides a larger list of lm75-compatible chips- A top comment now says what the driver does (!) ... as in, just what sort of sensor is this??
- Section comments now delineate the various sections of the driver:
hwmon attributes, driver binding, register access, module glue. One driver binding function moved out of the attribute section, as did the driver struct itself.- Minor tweaks to legacy probe logic: correct a comment, and remove a pointless variable.
- Whitespace, linelength, and comment fixes.
This patch should include no functional changes. It's preparation for adding new-style (driver model) I2C driver binding.
Quoted 7 lines
Signed-off-by David Brownell <[email protected]>Acked-by Jean Delvare <[email protected]>Acked-by Laurent Pinchart <[email protected]>--- drivers/hwmon/Kconfig | 20 +++++++---- drivers/hwmon/lm75.c | 90 ++++++++++++++++++++++++++++---------------------- 2 files changed, 64 insertions(+), 46 deletions(-)
Applied to hwmon-2.6.git/testing, thanks.
Signature · 8 lines
Mark M. Hoffman [email protected] _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 26 lines · Mark M. Hoffman
Hi David:
Quoted 23 lines · David Brownell
Minor cleanup and reorg of the lm75 code.
-
Kconfigprovides a larger list of lm75-compatible chips- A top comment now says what the driver does (!) ... as in, just what sort of sensor is this??
- Section comments now delineate the various sections of the driver:
hwmon attributes, driver binding, register access, module glue. One driver binding function moved out of the attribute section, as did the driver struct itself.- Minor tweaks to legacy probe logic: correct a comment, and remove a pointless variable.
- Whitespace, linelength, and comment fixes.
This patch should include no functional changes. It's preparation for adding new-style (driver model) I2C driver binding.
Signed-off-by David Brownell <[email protected]>Acked-by Jean Delvare <[email protected]>Acked-by Laurent Pinchart <[email protected]>
I've run some testing on these with our TI TMP101 based systems, and it works for us. I would recommend these going into the next kernel release.
Signature · 10 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year. _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 3 lines · Ben Dooks
I've run some testing on these with our TI TMP101 based systems, and it works for us. I would recommend these going into the next kernel release.
Just to clarify: by "next" do you mean "2.6.26" or "2.6.27" ?
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors