cciss: bump version to .20 to reflect new HW support
Subsystems (2)
PATCH 2/2 cciss: bump version to .20 to reflect new HW support
PATCH 2/2
This patch bumps the driver version to 3.6.20 to reflect the new hardware support from patch 1 of this set. Please consider this for inclusion.
drivers/block/cciss.c +4 -4
@@ -53,16 +53,16 @@#include <linux/scatterlist.h> #define CCISS_DRIVER_VERSION (maj,min,submin) ((maj<<16)|(min<<8)|(submin)) -#define DRIVER_NAME "HP CISS Driver (v 3.6.14)" -#define DRIVER_VERSION CCISS_DRIVER_VERSION(3,6,14) +#define DRIVER_NAME "HP CISS Driver (v 3.6.20)" +#define DRIVER_VERSION CCISS_DRIVER_VERSION(3, 6, 20)/* Embedded module documentation macros - see modules.h */ MODULE_AUTHOR ("Hewlett-Packard Company" ); -MODULE_DESCRIPTION ("Driver for HP Controller SA5xxx SA6xxx version 3.6.14" ); +MODULE_DESCRIPTION ("Driver for HP Smart Array Controllers" );MODULE_SUPPORTED_DEVICE ("HP SA5i SA5i+ SA532 SA5300 SA5312 SA641 SA642 SA6400" " SA6i P600 P800 P400 P400i E200 E200i E500 P700m" " Smart Array G2 Series SAS/SATA Controllers" ); -MODULE_VERSION ("3.6.14" ); +MODULE_VERSION ("3.6.20" );MODULE_LICENSE ("GPL" );#include "cciss_cmd.h"
Quoted 21 lines · On Tue, 10 Jun 2008 11:14:04 -0500 Mike Miller <[email protected]> wrote:
PATCH 2/2
This patch bumps the driver version to 3.6.20 to reflect the new hardware support from patch 1 of this set. Please consider this for inclusion.Signed-off-by Mike Miller <[email protected]>drivers/block/cciss.c +2
-2@@ -53,16 +53,16 @@#include <linux/scatterlist.h> #define CCISS_DRIVER_VERSION (maj,min,submin) ((maj<<16)|(min<<8)|(submin)) -#define DRIVER_NAME "HP CISS Driver (v 3.6.14)" -#define DRIVER_VERSION CCISS_DRIVER_VERSION(3,6,14) +#define DRIVER_NAME "HP CISS Driver (v 3.6.20)" +#define DRIVER_VERSION CCISS_DRIVER_VERSION(3, 6, 20)/* Embedded module documentation macros - see modules.h */ MODULE_AUTHOR ("Hewlett-Packard Company" );
drivers/block/cciss.c line 68
Quoted 10 lines
drivers/block/cciss.c +2
-2-MODULE_DESCRIPTION ("Driver for HP Controller SA5xxx SA6xxx version 3.6.14" ); +MODULE_DESCRIPTION ("Driver for HP Smart Array Controllers" );MODULE_SUPPORTED_DEVICE ("HP SA5i SA5i+ SA532 SA5300 SA5312 SA641 SA642 SA6400" " SA6i P600 P800 P400 P400i E200 E200i E500 P700m" " Smart Array G2 Series SAS/SATA Controllers" ); -MODULE_VERSION ("3.6.14" ); +MODULE_VERSION ("3.6.20" );MODULE_LICENSE ("GPL" );#include "cciss_cmd.h"
I think it would be more logical to fold these two patches together.
I believe we should include this new device support in 2.6.25.x, yes?
Quoted 46 lines
-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Tuesday, June 10, 2008 3:50 PM
To: Miller, Mike (OS Dev)
Cc: [email protected]; [email protected]; [email protected]; Patterson, Andrew D (Linux R&D); Chen, Justin
Subject: Re: [PATCH 2/2] cciss: bump version to .20 to reflect new HW supportQuoted 3 lines · On Tue, 10 Jun 2008 11:14:04 -0500 Mike Miller <[email protected]> wrote:
PATCH 2/2
This patch bumps the driver version to 3.6.20 to reflect the new hardware support from patch 1 of this set. Please considerthis for inclusion.
Quoted 11 lines
Signed-off-by Mike Miller <[email protected]>drivers/block/cciss.c index renamed from drivers/block/cciss.c +0
-0ced904d..c21a5a9 100644
drivers/block/cciss.c +0
-0@@ -53,16 +53,16 @@#include <linux/scatterlist.h> #define CCISS_DRIVER_VERSION (maj,min,submin)Quoted 1 line
((maj<<16)|(min<<8)|(submin)) -#define
DRIVER_NAME"HP CISSDriver (v 3.6.14)"
Quoted 6 lines
drivers/block/cciss.c +2
-1-#define DRIVER_VERSION CCISS_DRIVER_VERSION(3,6,14) +#define DRIVER_NAME "HP CISS Driver (v 3.6.20)" +#define DRIVER_VERSION CCISS_DRIVER_VERSION(3, 6, 20)/* Embedded module documentation macros - see modules.h */
MODULE_AUTHOR("Hewlett-Packard Company");-MODULE_DESCRIPTION("Driver
Quoted 3 lines
for HP Controller SA5xxx SA6xxx version 3.6.14"); +MODULE_DESCRIPTION("Driver for HP Smart Array Controllers");
MODULE_SUPPORTED_DEVICE("HP SA5i SA5i+ SA532 SA5300 SA5312SA641 SA642 SA6400"
Quoted 1 line
" SA6i P600 P800 P400 P400i E200E200i E500 P700m"
Quoted 1 line
" Smart Array G2 Series SAS/SATA
Quoted 8 lines
Controllers");
drivers/block/cciss.c line 68
Quoted 5 lines
drivers/block/cciss.c +1
-1-MODULE_VERSION ("3.6.14" ); +MODULE_VERSION ("3.6.20" );MODULE_LICENSE ("GPL" );#include "cciss_cmd.h" I think it would be more logical to fold these two patches together.
Jens at one time suggested I keep the version patch separate, IIRC.
Quoted 2 lines
I believe we should include this new device support in 2.6.25.x, yes?
Yes, I'd like to see the support in 2.6.25.x.
-- mikem
Quoted 1 line
Quoted 51 lines · Mike (OS Dev)
Quoted 51 lines
-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Tuesday, June 10, 2008 3:50 PM
To: Miller, Mike (OS Dev)
Cc: [email protected]; [email protected]; [email protected]; Patterson, Andrew D (Linux R&D); Chen, Justin
Subject: Re: [PATCH 2/2] cciss: bump version to .20 to reflect new HW supportQuoted 3 lines · On Tue, 10 Jun 2008 11:14:04 -0500 Mike Miller <[email protected]> wrote:
PATCH 2/2
This patch bumps the driver version to 3.6.20 to reflect the new hardware support from patch 1 of this set. Please considerthis for inclusion.
Quoted 11 lines
Signed-off-by Mike Miller <[email protected]>drivers/block/cciss.c index renamed from drivers/block/cciss.c +0
-0ced904d..c21a5a9 100644
drivers/block/cciss.c +0
-0@@ -53,16 +53,16 @@#include <linux/scatterlist.h> #define CCISS_DRIVER_VERSION (maj,min,submin)Quoted 1 line
((maj<<16)|(min<<8)|(submin)) -#define
DRIVER_NAME"HP CISSDriver (v 3.6.14)"
Quoted 6 lines
drivers/block/cciss.c +2
-1-#define DRIVER_VERSION CCISS_DRIVER_VERSION(3,6,14) +#define DRIVER_NAME "HP CISS Driver (v 3.6.20)" +#define DRIVER_VERSION CCISS_DRIVER_VERSION(3, 6, 20)/* Embedded module documentation macros - see modules.h */
MODULE_AUTHOR("Hewlett-Packard Company");-MODULE_DESCRIPTION("Driver
Quoted 3 lines
for HP Controller SA5xxx SA6xxx version 3.6.14"); +MODULE_DESCRIPTION("Driver for HP Smart Array Controllers");
MODULE_SUPPORTED_DEVICE("HP SA5i SA5i+ SA532 SA5300 SA5312SA641 SA642 SA6400"
Quoted 1 line
" SA6i P600 P800 P400 P400i E200E200i E500 P700m"
Quoted 1 line
" Smart Array G2 Series SAS/SATA
Controllers");
Quoted 4 lines
drivers/block/cciss.c +1
-1-MODULE_VERSION ("3.6.14" ); +MODULE_VERSION ("3.6.20" );MODULE_LICENSE ("GPL" );
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
#include "
cciss_cmd.h"I think it would be more logical to fold these two patches together.
Jens at one time suggested I keep the version patch separate, IIRC.
Did I? For a series of patches implementing various things, bumping the version at the end makes sense since it's tied to the series and not a specific patch. For a single patch, I'm fine with including the version change in there.
Signature · 1 line
Jens Axboe
Quoted 70 lines
-----Original Message-----
From: Jens Axboe [mailto:[email protected]]
Sent: Tuesday, June 10, 2008 4:18 PM
To: Miller, Mike (OS Dev)
Cc: Andrew Morton; [email protected]; [email protected]; Patterson, Andrew D (Linux R&D); Chen, Justin
Subject: Re: [PATCH 2/2] cciss: bump version to .20 to reflect new HW supportQuoted 8 lines · Mike (OS Dev)
Quoted 8 lines
-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Tuesday, June 10, 2008 3:50 PM
To: Miller, Mike (OS Dev)
Cc: [email protected]; [email protected]; [email protected]; Patterson, Andrew D (LinuxR&D); Chen,
Quoted 2 lines
Quoted 2 lines
Justin
Subject: Re: [PATCH 2/2] cciss: bump version to .20 toreflect new
Quoted 7 lines
Quoted 7 lines
HW support
Quoted 2 lines · On Tue, 10 Jun 2008 11:14:04 -0500 Mike Miller <[email protected]> wrote:
PATCH 2/2
This patch bumps the driver version to 3.6.20 toreflect the new
Quoted 29 lines
Quoted 29 lines
Quoted 1 line
hardware support from patch 1 of this set. Please consider
this for inclusion.
Quoted 11 lines
Signed-off-by Mike Miller <[email protected]>drivers/block/cciss.c index renamed from drivers/block/cciss.c +0
-0ced904d..c21a5a9 100644
drivers/block/cciss.c +0
-0@@ -53,16 +53,16 @@#include <linux/scatterlist.h> #define CCISS_DRIVER_VERSION (maj,min,submin)Quoted 1 line
((maj<<16)|(min<<8)|(submin)) -#define
DRIVER_NAME"HP CISSDriver (v 3.6.14)"
Quoted 6 lines
drivers/block/cciss.c +2
-1-#define DRIVER_VERSION CCISS_DRIVER_VERSION(3,6,14) +#define DRIVER_NAME "HP CISS Driver (v 3.6.20)" +#define DRIVER_VERSION CCISS_DRIVER_VERSION(3, 6, 20)/* Embedded module documentation macros - see modules.h */
MODULE_AUTHOR("Hewlett-Packard Company");-MODULE_DESCRIPTION("Driver
Quoted 3 lines
for HP Controller SA5xxx SA6xxx version 3.6.14"); +MODULE_DESCRIPTION("Driver for HP Smart Array Controllers");
MODULE_SUPPORTED_DEVICE("HP SA5i SA5i+ SA532 SA5300 SA5312SA641 SA642 SA6400"
Quoted 1 line
" SA6i P600 P800 P400 P400i E200E200i E500 P700m"
Quoted 1 line
" Smart Array G2 Series SAS/SATA
Quoted 8 lines
Quoted 8 lines
Controllers");
drivers/block/cciss.c line 68
Quoted 5 lines
drivers/block/cciss.c +1
-1-MODULE_VERSION ("3.6.14" ); +MODULE_VERSION ("3.6.20" );MODULE_LICENSE ("GPL" );#include "cciss_cmd.h" I think it would be more logical to fold these two
Quoted 8 lines
patches together.
Quoted 2 lines
Jens at one time suggested I keep the version patch separate, IIRC.
Did I? For a series of patches implementing various things, bumping the version at the end makes sense since it's tied to the series and not a specific patch. For a single patch, I'm fine with including the version change in there.
OK, thanks.
Quoted 5 lines
--
Jens Axboe