Skip to contentSkip to conversation

swarm: use struct ide_port_info

PATCH Maciej W. Rozycki 2 participants 3 messages Jun 8, 2008 – Jun 11, 2008 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Maciej W. Rozycki

author Acked-by
#1 lore raw
Quoted 7 lines · Bartlomiej Zolnierkiewicz

Convert the driver to use struct ide_port_info.

There should be no functional changes caused by this patch.

---

Verified to work correctly on my system, thanks.

Review

Quoted 1 line
(quoted diff) +1 -0
+	.host_flags		= IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,

You could have saved one <Tab> here. ;)

Maciej

#2 lore raw
Quoted 6 lines · Maciej W. Rozycki
Quoted 4 lines · Bartlomiej Zolnierkiewicz

Convert the driver to use struct ide_port_info.

There should be no functional changes caused by this patch.

Quoted 7 lines
Quoted 3 lines

---

Verified to work correctly on my system, thanks.

Thanks, I added Acked-by: + Tested-by: to the patch.

Quoted 3 lines

Review

Quoted 1 line
(quoted diff) +1 -0
+	.host_flags		= IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,

You could have saved one <Tab> here. ;)

Well, yes but it matches other host drivers (which need two <Tab>s). :)

Bart

#3 lore raw
Quoted 1 line · Bartlomiej Zolnierkiewicz

Well, yes but it matches other host drivers (which need two <Tab>s). :)

Good luck to the lucky <Tab> then! ;)

Maciej