driver/video/cirrusfb : Fix RAM address printk
PATCH 1/1 driver/video/cirrusfb : Fix RAM address printk
Hello everybody,
In the cirrusfb driver, the RAM address printk has a superfluous 'x' that could be interpreted as "don't care", while it is actually a typo. Fix that.
drivers/video/cirrusfb.c +1 -1
@@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct info->screen_size = board_size; cinfo->unmap = cirrusfb_pci_unmap; -printk (KERN_INFO " RAM (%lu kB) at 0xx%lx, " , +printk (KERN_INFO " RAM (%lu kB) at 0x%lx, " , info->screen_size >>10 , board_addr);printk (KERN_INFO "Cirrus Logic chipset on PCI bus\n" );pci_set_drvdata (pdev, info);
Quoted 12 lines · Philippe De Muyter
Hello everybody,
In the cirrusfb driver, the RAM address printk has a superfluous 'x' that could be interpreted as "don't care", while it is actually a typo. Fix that.
Signed-off-by Philippe De Muyter <[email protected]>diff -r
184e1bb486cfdrivers/video/cirrusfb.c
drivers/video/cirrusfb.c static int cirrusfb_pci_register(struct · line 2436
Quoted 6 lines
drivers/video/cirrusfb.c +1
-1@@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct info->screen_size = board_size; cinfo->unmap = cirrusfb_pci_unmap; -printk (KERN_INFO " RAM (%lu kB) at 0xx%lx, " , +printk (KERN_INFO " RAM (%lu kB) at 0x%lx, " , info->screen_size >>10 , board_addr);
Hmm, is there \n missing too?
Quoted 2 lines
drivers/video/cirrusfb.c +0
-0printk (KERN_INFO "Cirrus Logic chipset on PCI bus\n" );pci_set_drvdata (pdev, info);
Quoted 18 lines · Jiri Slaby
Quoted 9 lines · Philippe De Muyter
Hello everybody,
In the cirrusfb driver, the RAM address printk has a superfluous 'x' that could be interpreted as "don't care", while it is actually a typo. Fix that.Signed-off-by Philippe De Muyter <[email protected]>diff -r
184e1bb486cfdrivers/video/cirrusfb.cdrivers/video/cirrusfb.c static int cirrusfb_pci_register(struct · line 2436
Quoted 5 lines
drivers/video/cirrusfb.c +1
-0@@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct info->screen_size = board_size; cinfo->unmap = cirrusfb_pci_unmap; -printk (KERN_INFO " RAM (%lu kB) at 0xx%lx, " , +printk (KERN_INFO " RAM (%lu kB) at 0x%lx, " , info->screen_size >> 10, board_addr);Hmm, is there \n missing too?
No that would make the RAM adress orphan, but we must also remove KERN_INFO in the printk below.
Quoted 2 lines
Quoted 2 lines
drivers/video/cirrusfb.c +0
-0printk (KERN_INFO "Cirrus Logic chipset on PCI bus\n" );pci_set_drvdata (pdev, info);
Quoted 19 lines · Philippe De Muyter
Quoted 17 lines · Jiri Slaby
Quoted 9 lines · Philippe De Muyter
Hello everybody,
In the cirrusfb driver, the RAM address printk has a superfluous 'x' that could be interpreted as "don't care", while it is actually a typo. Fix that.Signed-off-by Philippe De Muyter <[email protected]>diff -r
184e1bb486cfdrivers/video/cirrusfb.cdrivers/video/cirrusfb.c static int cirrusfb_pci_register(struct · line 2436
Quoted 5 lines
drivers/video/cirrusfb.c +1
-0@@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct info->screen_size = board_size; cinfo->unmap = cirrusfb_pci_unmap; -printk (KERN_INFO " RAM (%lu kB) at 0xx%lx, " , +printk (KERN_INFO " RAM (%lu kB) at 0x%lx, " , info->screen_size >> 10, board_addr);Hmm, is there \n missing too?
Quoted 2 lines
No that would make the RAM adress orphan, but we must also remove
KERN_INFOin the printk below.
No please. This makes logs non-atomic. Make one printk from the two.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
drivers/video/cirrusfb.c +0
-0printk (KERN_INFO "Cirrus Logic chipset on PCI bus\n" );pci_set_drvdata (pdev, info);