Skip to contentSkip to conversation

rt2x00: RT2X00_LIB_RFKILL should depend on INPUT

PATCH In review Ivo van Doorn 1 participant 2 messages Jun 11, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Ivo van Doorn

author
#0 lore raw

PATCH 1/1 rt2x00: RT2X00_LIB_RFKILL should depend on INPUT

rt2x00 requires the input-polldev driver for reporting rfkill events, selecting INPUT_POLLDEV is not correct since that option depends on the INPUT config option.
Since RT2X00_LIB_RFKILL requires the input layer as well, we should make it depend on INPUT directly.

Signed-off-by Ivo van Doorn <[email protected]>

---
John, this is for 2.6.26

drivers/net/wireless/rt2x00/Kconfig +1 -0
index 0ace761..c4d1f67 100644
@@ -36,6 +36,7 @@ config RT2X00_LIB_FIRMWARE
 config RT2X00_LIB_RFKILL
 	boolean
 	depends on RT2X00_LIB
+	depends on INPUT
 	select RFKILL
 	select INPUT_POLLDEV
author
#1 lore raw
Quoted 7 lines · Ivo van Doorn

rt2x00 requires the input-polldev driver for reporting rfkill events, selecting INPUT_POLLDEV is not correct since that option depends on the INPUT config option.
Since RT2X00_LIB_RFKILL requires the input layer as well, we should make it depend on INPUT directly.

Signed-off-by Ivo van Doorn <[email protected]>

John, you can drop this patch in exchange for the patch just send by Randy, since that patch would be more correct.

Thanks,

Ivo

Quoted 16 lines

---
John, this is for 2.6.26

drivers/net/wireless/rt2x00/Kconfig +1 -0
index 0ace761..c4d1f67 100644
@@ -36,6 +36,7 @@ config RT2X00_LIB_FIRMWARE
 config RT2X00_LIB_RFKILL
 	boolean
 	depends on RT2X00_LIB
+	depends on INPUT
 	select RFKILL
 	select INPUT_POLLDEV