Cant compile 2.6.26-rc5-mm2 kernel
For whom it concerns:
Hello!
Today i`ve tried to compile a linux-2.6.26-rc5-mm2 kernel obtained with the Ketchup tool.
It got halfway interupted with the following error messages:
CC [M] fs/xfs/support/debug.o
CC [M] fs/xfs/support/uuid.o
LD [M] fs/xfs/xfs.o
CC fs/quota.ofs/quota.c: In function 'quota_sync_sb':fs/quota.c:174: error: implicit declaration of function 'sb_dqopt' fs/quota.c:174: error: invalid type argument of '->' fs/quota.c:180: error: invalid type argument of '->' fs/quota.c:181: error: invalid type argument of '->' fs/quota.c:182: error: invalid type argument of '->' fs/quota.c:184: error: invalid type argument of '->' fs/quota.c: In function 'sync_dquots':fs/quota.c:206: error: invalid type argument of '->' fs/quota.c:207: error: invalid type argument of '->' fs/quota.c: In function 'do_quotactl':fs/quota.c:247: error: invalid type argument of '->' fs/quota.c:249: error: invalid type argument of '->' fs/quota.c:252: error: invalid type argument of '->' fs/quota.c:253: error: invalid type argument of '->' make[1]: *** [fs/quota.o] Error 1
make: *** [fs] Error 2
I have made 5 attempts to recompile the source with the same result.
Here is the output of the ver_linux script as i understand it may be helpfull:
Linux raptor 2.6.24-gentoo-r8 #2 SMP PREEMPT Thu Jun 5 16:16:17 CEST 2008 i686 Genuine Intel(R) CPU T2080 @ 1.73GHz GenuineIntel GNU/Linux
Gnu C 4.1.2
Gnu make 3.81
binutils 2.18
util-linux 2.13.1.1
mount 2.13.1.1
module-init-tools 3.4
e2fsprogs 1.40.9
reiserfsprogs 3.6.19
pcmciautils 014
Linux C Library 2.6.1
Dynamic linker (ldd) 2.6.1
Procps 3.2.7
Net-tools 1.60
Kbd 1.13
Sh-utils 6.10
udev 119
wireless-tools 29
Modules Loaded ipv6 af_packet snd_pcm_oss snd_mixer_oss snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device usbmouse pcmcia usbhid hid joydev arc4 ecb pcspkr psmouse blkcipher yenta_socket serio_raw sdhci rsrc_nonstatic mmc_core ehci_hcd uhci_hcd pcmcia_core i2c_i801 ath5k usbcore mac80211 cfg80211 snd_hda_intel snd_pcm snd_timer snd video battery container ac thermal output nvidia soundcore processor button snd_page_alloc intel_agp agpgart i2c_core evdev
I hope this is enough information to work with.
if there is more, im happy to provde it.
Arjen Pool
Hi,
Thanks for the report.
Quoted 11 lines · On Wed, Jun 11, 2008 at 8:08 PM, <[email protected]> wrote:
Today i`ve tried to compile a linux-2.6.26-rc5-mm2 kernel obtained with the Ketchup tool.
It got halfway interupted with the following error messages:
CC [M]
fs/xfs/support/debug.o
CC [M]fs/xfs/support/uuid.o
LD [M]fs/xfs/xfs.o
CCfs/quota.ofs/quota.c: In function 'quota_sync_sb':fs/quota.c:174: error: implicit declaration of function 'sb_dqopt'
It seems that this definition is needed regardless of CONFIG_QUOTA.
I'm attaching a patch that fixes it for me. I'm not 100% it's the right thing.
Vegard
Quoted 1 line
From
5fc276129d8a3e2a70980104cc374bdc0d61afa3Mon Sep 17 00:00:00 2001
From: Vegard Nossum <[email protected]>
Date: Wed, 11 Jun 2008 21:58:32 +0200
Subject: [PATCH] fs: fix build breakage
The patch
| commit 9651a656c9fbf3e8183b5eb21740edc1eb9ca16b | Author: Jan Kara <[email protected]> | Date: Thu Jun 5 19:53:42 2008 +0000 | | quota-move-function-macros-from-quotah-to-quotaopsh |
causes the build to break for CONFIG_QUOTA=n.
--- include/linux/quotaops.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
include/linux/quotaops.h +5 -5
@@ -14,6 +14,11 @@#include <linux/fs.h> +static inline struct quota_info *sb_dqopt (struct super_block *sb) +{ +return &sb->s_dquot; +} +#if defined(CONFIG_QUOTA )/*
@@ -52,11 +57,6 @@ void vfs_dq_drop(struct inode *inode);int vfs_dq_transfer (struct inode *inode,struct iattr *iattr);int vfs_dq_quota_on_remount (struct super_block *sb); -static inline struct quota_info *sb_dqopt (struct super_block *sb) -{ -return &sb->s_dquot; -} -static inline struct mem_dqinfo *sb_dqinfo (struct super_block *sb,int type) {return sb_dqopt (sb)->info + type;
Signature · 1 line
1.5.4.1
Quoted 17 lines · Vegard Nossum
Hi,
Thanks for the report.
Quoted 11 lines · On Wed, Jun 11, 2008 at 8:08 PM, <[email protected]> wrote:
Today i`ve tried to compile a linux-2.6.26-rc5-mm2 kernel obtained with the Ketchup tool.
It got halfway interupted with the following error messages:
CC [M]
fs/xfs/support/debug.o
CC [M]fs/xfs/support/uuid.o
LD [M]fs/xfs/xfs.o
CCfs/quota.ofs/quota.c: In function 'quota_sync_sb':fs/quota.c:174: error: implicit declaration of function 'sb_dqopt'
Quoted 4 lines
It seems that this definition is needed regardless of
CONFIG_QUOTA.I'm attaching a patch that fixes it for me. I'm not 100% it's the right thing.
Yes, it is the right thing. I forgot to test compilation with XFS and
quotas off... Thanks for fixing this.
You can add: Acked-by: Jan Kara <[email protected]>
Honza
Quoted 54 lines
From
5fc276129d8a3e2a70980104cc374bdc0d61afa3Mon Sep 17 00:00:00 2001
From: Vegard Nossum <[email protected]>
Date: Wed, 11 Jun 2008 21:58:32 +0200
Subject: [PATCH] fs: fix build breakageThe patch
| commit 9651a656c9fbf3e8183b5eb21740edc1eb9ca16b | Author: Jan Kara <[email protected]> | Date: Thu Jun 5 19:53:42 2008 +0000 | | quota-move-function-macros-from-quotah-to-quotaopsh |causes the build to break for
CONFIG_QUOTA=n.Reported-by Arjen Pool <[email protected]>Cc Jan Kara <[email protected]>Signed-off-by Vegard Nossum <[email protected]>--- include/linux/quotaops.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)include/linux/quotaops.h +5
-5@@ -14,6 +14,11 @@#include <linux/fs.h> +static inline struct quota_info *sb_dqopt (struct super_block *sb) +{ +return &sb->s_dquot; +} +#if defined(CONFIG_QUOTA )/* @@ -52,11 +57,6 @@ void vfs_dq_drop(struct inode *inode);int vfs_dq_transfer (struct inode *inode,struct iattr *iattr);int vfs_dq_quota_on_remount (struct super_block *sb); -static inline struct quota_info *sb_dqopt (struct super_block *sb) -{ -return &sb->s_dquot; -} -static inline struct mem_dqinfo *sb_dqinfo (struct super_block *sb,int type) {return sb_dqopt (sb)->info + type;Signature · 1 line
1.5.4.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR