Skip to contentSkip to conversation

ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs

PATCH In review Michael Buesch 2 participants 3 messages Jun 13, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs

From: [email protected]

In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4 SPROM's.

---

John, this is a bugfix for 2.6.26.

ssb_sprom.h +2 -2
Index: ssb_sprom/ssb_sprom.h
===================================================================
@@ -33,10 +33,10 @@
 
 /* byte offsets */
 #define SPROM_SUBP		(0x02 * 2)
-#define SPROM4_SUBP		(0x00 * 2)
+#define SPROM4_SUBP		(0x02 * 2)
 #define SPROM_SUBV		(0x03 * 2)
 #define SPROM_PPID		(0x04 * 2)
-#define SPROM4_PPID		(0x02 * 2)
+#define SPROM4_PPID		(0x04 * 2)
 #define SPROM_BFLHI		(0x1C * 2)
 #define SPROM_IL0MACADDR	(0x24 * 2)
 #define SPROM_ET0MACADDR	(0x27 * 2)
Signature · 1 line
Greetings Michael.
#1 lore raw
Quoted 20 lines · Michael Buesch

From: [email protected]

In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4 SPROM's.

---

John, this is a bugfix for 2.6.26.

Index: ssb_sprom/ssb_sprom.h
===================================================================

ssb_sprom.h +0 -0
@@ -33,10 +33,10 @@
 
 /* byte offsets */

ssb_sprom.h line 42

Quoted 10 lines
ssb_sprom.h +2 -2
 #define SPROM_SUBP		(0x02 * 2)
-#define SPROM4_SUBP		(0x00 * 2)
+#define SPROM4_SUBP		(0x02 * 2)
 #define SPROM_SUBV		(0x03 * 2)
 #define SPROM_PPID		(0x04 * 2)
-#define SPROM4_PPID		(0x02 * 2)
+#define SPROM4_PPID		(0x04 * 2)
 #define SPROM_BFLHI		(0x1C * 2)
 #define SPROM_IL0MACADDR	(0x24 * 2)
 #define SPROM_ET0MACADDR	(0x27 * 2)

The patch is for ssb-sprom, not ssb. If I still have any of my feeble mind left, ssb-sprom has not become part of the kernel. John, you can ignore this patch.

Larry

#2 lore raw
In reply to Michael Buesch

ssb_sprom.h

Quoted 16 lines · On Friday 13 June 2008 10:47:33 Michael Buesch wrote:

From: [email protected]

In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4 SPROM's.

---

John, this is a bugfix for 2.6.26.

Index: ssb_sprom/ssb_sprom.h
===================================================================

ssb_sprom.h +0 -0

Oh, this changes the ssb userland tool. So I better apply it instead of sending it to random unrelated people :P

Quoted 14 lines
ssb_sprom.h +2 -2
@@ -33,10 +33,10 @@
 
 /* byte offsets */
 #define SPROM_SUBP		(0x02 * 2)
-#define SPROM4_SUBP		(0x00 * 2)
+#define SPROM4_SUBP		(0x02 * 2)
 #define SPROM_SUBV		(0x03 * 2)
 #define SPROM_PPID		(0x04 * 2)
-#define SPROM4_PPID		(0x02 * 2)
+#define SPROM4_PPID		(0x04 * 2)
 #define SPROM_BFLHI		(0x1C * 2)
 #define SPROM_IL0MACADDR	(0x24 * 2)
 #define SPROM_ET0MACADDR	(0x27 * 2)
Signature · 1 line
Greetings Michael.