Skip to contentSkip to conversation

Fix 4xx build issue

PATCH New Anatolij Gustschin 5 participants 7 messages Jun 12, 2008 – Jun 19, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix 4xx build issue

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver' make[1]: *** [4xx_pcie.o] Error 1

This patch fixes the problem.

---
 cpu/mpc85xx/cpu.c           |    2 +-
 include/asm-ppc/processor.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
cpu/mpc85xx/cpu.c +1 -1
index 2b7e753..baf8b81 100644
@@ -59,7 +59,7 @@ struct cpu_type cpu_type_list [] = {
 	CPU_TYPE_ENTRY(8572, 8572_E),
 };
 
-struct cpu_type *identify_cpu(uint ver)
+struct cpu_type *identify_cpu(u32 ver)
 {
 	int i;
 	for (i = 0; i < ARRAY_SIZE(cpu_type_list); i++)
include/asm-ppc/processor.h +1 -1
index 139e686..5b50679 100644
@@ -968,7 +968,7 @@ struct cpu_type {
 	u32 soc_ver;
 };
 
-struct cpu_type *identify_cpu(uint ver);
+struct cpu_type *identify_cpu(u32 ver);
 
 #define CPU_TYPE_ENTRY(n, v) \
 	{ .name = #n, .soc_ver = SVR_##v, }
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 Fix 4xx build issue

Quoted 9 lines · Anatolij Gustschin

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver' make[1]: *** [4xx_pcie.o] Error 1

This patch fixes the problem.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 1/1 Fix 4xx build issue

Quoted 7 lines · Stefan Roese
Quoted 6 lines · Anatolij Gustschin

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver' make[1]: *** [4xx_pcie.o] Error 1

Quoted 5 lines
Quoted 3 lines

This patch fixes the problem.

- k

#3 lore raw

PATCH 1/1 Fix 4xx build issue

In reply to Stefan Roese
Quoted 9 lines · Stefan Roese
Quoted 8 lines · Anatolij Gustschin

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver' make[1]: *** [4xx_pcie.o] Error 1

This patch fixes the problem.

Quoted 8 lines
Quoted 1 line

Thanks.

Best regards,
Stefan

Thanks from me too, Anatolij. I just came up with the same patch, but decided to check the mailing list before submitting it.

Stefan, could you add this to the ppc4xx repository ASAP?

Best regards,
Larry

#4 lore raw

PATCH 1/1 Fix 4xx build issue

Quoted 4 lines · Larry Johnson

Thanks from me too, Anatolij. I just came up with the same patch, but decided to check the mailing list before submitting it.

Stefan, could you add this to the ppc4xx repository ASAP?

No, I can't. This patch touches non-PPC4xx files so it shouldn't be integrated via the 4xx repository.

Wolfgang, could you please apply it directly soon? Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#5 lore raw

PATCH 1/1 Fix 4xx build issue

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 2 lines

Stefan, could you add this to the ppc4xx repository ASAP?

No, I can't. This patch touches non-PPC4xx files so it shouldn't be integrated via the 4xx repository.

Wolfgang, could you please apply it directly soon? Thanks.

Done.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good marriage would be between a blind wife and deaf husband.
                                               -- Michel de Montaigne
#6 lore raw

PATCH 1/1 Fix 4xx build issue

In reply to Anatolij Gustschin
Quoted 9 lines · In message <[email protected]> you wrote:

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver' make[1]: *** [4xx_pcie.o] Error 1

This patch fixes the problem.

Applied, thanks!

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A mouse is an elephant built by the Japanese.