Skip to contentSkip to conversation

ide: increase timeout in wait_drive_not_busy()

PATCH New Bartlomiej Zolnierkiewicz 1 participant 1 message Jun 15, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide: increase timeout in wait_drive_not_busy()

Some ATAPI devices take longer than the current max timeout value to become ready (i.e. TEAC DV-W28ECW takes 6 ms) so increase the timeout value to 10 ms.

This fixes kernel.org bugzilla bug #10887:
http://bugzilla.kernel.org/show_bug.cgi?id=10887

---
draft patch, I'm waiting on feedback from Masanari on this one

 drivers/ide/ide-taskfile.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ide/ide-taskfile.c +3 -3
Index: b/drivers/ide/ide-taskfile.c
===================================================================
@@ -225,10 +225,10 @@ static u8 wait_drive_not_busy(ide_drive_
 	u8 stat;
 
 	/*
-	 * Last sector was transfered, wait until drive is ready.
-	 * This can take up to 10 usec, but we will wait max 1 ms.
+	 * Last sector was transfered, wait until device is ready.  This can
+	 * take up to 6 ms on some ATAPI devices, so we will wait max 10 ms.
 	 */
-	for (retries = 0; retries < 100; retries++) {
+	for (retries = 0; retries < 1000; retries++) {
 		stat = ide_read_status(drive);
 
 		if (stat & BUSY_STAT)