matroxfb: i2c structure templates clean-up
PATCH 2/3 matroxfb: i2c structure templates clean-up
Clean up the use of structure templates in i2c-matroxfb. For one thing, a real template is supposed to be read-only. And in some cases it's more efficient to initialize the few fields we need individually. This makes i2c-matroxfb.ko 16% smaller on my system.
Signed-off-by Jean Delvare <[email protected]>
--- drivers/video/matrox/i2c-matroxfb.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/video/matrox/i2c-matroxfb.c +3 -8
@@ -87,13 +87,7 @@ static int matroxfb_gpio_getscl(void* dareturn (matroxfb_read_gpio (b->minfo) & b->mask.clock) ?1 :0 ; } -static struct i2c_adapter matrox_i2c_adapter_template = -{ - .owner =THIS_MODULE , - .id =I2C_HW_B_G400 , -}; - -static struct i2c_algo_bit_data matrox_i2c_algo_template = +static const struct i2c_algo_bit_data matrox_i2c_algo_template = { .setsda = matroxfb_gpio_setsda, .setscl = matroxfb_gpio_setscl,
@@ -110,7 +104,8 @@ static int i2c_bus_reg(struct i2c_bit_ad b->minfo = minfo; b->mask.data = data; b->mask.clock = clock; - b->adapter = matrox_i2c_adapter_template; + b->adapter.owner =THIS_MODULE ; + b->adapter.id =I2C_HW_B_G400 ;snprintf (b->adapter.name,sizeof (b->adapter.name), name, minfo->fbcon.node);i2c_set_adapdata (&b->adapter, b);
Signature · 7 lines
Jean Delvare ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php