Skip to contentSkip to conversation

ide: filter out invalid transfer mode values in set_xfer_rate()

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Jun 21, 2008 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 3/4 ide: filter out invalid transfer mode values in set_xfer_rate()

Filter out invalid transfer mode values (0x02-0x07) in write handler for obsoleted /proc/ide/hd?/settings:current_speed setting.

While at it:

* Use XFER_UDMA_6 define.

Suggested-by Sergei Shtylyov <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
Sergei, IIRC that it is what you were suggesting some time ago.

drivers/ide/ide-proc.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ide/ide-proc.c +1 -1
Index: b/drivers/ide/ide-proc.c
===================================================================
@@ -345,7 +345,7 @@ static int set_xfer_rate (ide_drive_t *d
 	ide_task_t task;
 	int err;
 
-	if (arg < 0 || arg > 70)
+	if (arg < 0 || (arg > 1 && arg < XFER_PIO_0) || arg > XFER_UDMA_6)
 		return -EINVAL;
 
 	memset(&task, 0, sizeof(task));
#1 lore raw

Hello.

Quoted 12 lines · Bartlomiej Zolnierkiewicz

Filter out invalid transfer mode values (0x02-0x07) in write handler for obsoleted /proc/ide/hd?/settings:current_speed setting.

While at it:

* Use XFER_UDMA_6 define.

Suggested-by Sergei Shtylyov <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
Sergei, IIRC that it is what you were suggesting some time ago.

Maybe I did. :-) But I don't see what that gives to us now...

WBR, Sergei

author
#2 lore raw
Quoted 10 lines · Sergei Shtylyov

Hello.

Quoted 7 lines · Bartlomiej Zolnierkiewicz

Filter out invalid transfer mode values (0x02-0x07) in write handler for obsoleted /proc/ide/hd?/settings:current_speed setting.

While at it:

* Use XFER_UDMA_6 define.

Quoted 7 lines
Quoted 5 lines
Suggested-by Sergei Shtylyov <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
Sergei, IIRC that it is what you were suggesting some time ago.

Maybe I did. :-) But I don't see what that gives to us now...

One free IDE_HFLAG_ host flag (in patch #4/4)!! :)

[ I just went through backlog of lower-prio TODO items. ]